[MediaWiki-commits] [Gerrit] Actually display a button to try after errors in the 'Detail... - change (mediawiki...UploadWizard)

2015-09-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Actually display a button to try after errors in the 'Details' 
step
..


Actually display a button to try after errors in the 'Details' step

Typos, eh. Follow-up to d639454893a04b413b2013b0a67bd35a2f36bff6.

Also fixed some buttons where the label did not display.

Bug: T106968
Change-Id: Ibacf6e342deef1a5a56416a5f263fe57175d3140
---
M resources/ui/uw.ui.Details.js
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  MarkTraceur: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ui/uw.ui.Details.js b/resources/ui/uw.ui.Details.js
index 476e4d2..ddd81bd 100644
--- a/resources/ui/uw.ui.Details.js
+++ b/resources/ui/uw.ui.Details.js
@@ -75,18 +75,18 @@
} );
 
this.retryButtonSomeFailed = new oo.ui.ButtonWidget( {
-   label: mw.message( 'mwe-upwiz-file-retry' ),
+   label: mw.message( 'mwe-upwiz-file-retry' ).text(),
flags: [ 'progressive', 'primary' ]
} ).on( 'click', startDetails );
 
this.$div.find( '.mwe-upwiz-file-next-some-failed' ).append( 
this.nextButtonDespiteFailures.$element, this.retryButtonSomeFailed.$element );
 
this.retryButtonAllFailed = new oo.ui.ButtonWidget( {
-   label: mw.message( 'mwe-upwiz-file-retry' ),
+   label: mw.message( 'mwe-upwiz-file-retry' ).text(),
flags: [ 'progressive', 'primary' ]
} ).on( 'click', startDetails );
 
-   this.$div.find( '.mwe-upwiz-file-all-failed' ).append( 
this.retryButtonAllFailed.$element );
+   this.$div.find( '.mwe-upwiz-file-next-all-failed' ).append( 
this.retryButtonAllFailed.$element );
 
this.$errorCount = this.$div.find( 
'#mwe-upwiz-details-error-count' );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/237306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibacf6e342deef1a5a56416a5f263fe57175d3140
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: MarkTraceur 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Actually display a button to try after errors in the 'Detail... - change (mediawiki...UploadWizard)

2015-09-09 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/237306

Change subject: Actually display a button to try after errors in the 'Details' 
step
..

Actually display a button to try after errors in the 'Details' step

Typos, eh. Follow-up to d639454893a04b413b2013b0a67bd35a2f36bff6.

Also fixed some buttons where the label did not display.

Bug: T106968
Change-Id: Ibacf6e342deef1a5a56416a5f263fe57175d3140
---
M resources/ui/uw.ui.Details.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/06/237306/1

diff --git a/resources/ui/uw.ui.Details.js b/resources/ui/uw.ui.Details.js
index 476e4d2..ddd81bd 100644
--- a/resources/ui/uw.ui.Details.js
+++ b/resources/ui/uw.ui.Details.js
@@ -75,18 +75,18 @@
} );
 
this.retryButtonSomeFailed = new oo.ui.ButtonWidget( {
-   label: mw.message( 'mwe-upwiz-file-retry' ),
+   label: mw.message( 'mwe-upwiz-file-retry' ).text(),
flags: [ 'progressive', 'primary' ]
} ).on( 'click', startDetails );
 
this.$div.find( '.mwe-upwiz-file-next-some-failed' ).append( 
this.nextButtonDespiteFailures.$element, this.retryButtonSomeFailed.$element );
 
this.retryButtonAllFailed = new oo.ui.ButtonWidget( {
-   label: mw.message( 'mwe-upwiz-file-retry' ),
+   label: mw.message( 'mwe-upwiz-file-retry' ).text(),
flags: [ 'progressive', 'primary' ]
} ).on( 'click', startDetails );
 
-   this.$div.find( '.mwe-upwiz-file-all-failed' ).append( 
this.retryButtonAllFailed.$element );
+   this.$div.find( '.mwe-upwiz-file-next-all-failed' ).append( 
this.retryButtonAllFailed.$element );
 
this.$errorCount = this.$div.find( 
'#mwe-upwiz-details-error-count' );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/237306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibacf6e342deef1a5a56416a5f263fe57175d3140
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits