Spage has uploaded a new change for review. Change subject: Add EventLogging to ACUX ......................................................................
Add EventLogging to ACUX Define data model in JSON, add setUpLogging() and logEvent() wrappers around EventLogging, call my logEvent() instead of trackEvent(), eliminate obsolete trackXxx calls and drop jquery.clickTracking dependency! Do not merge; this is just for review to see how one client adapts to the new API. Glitches: * On error, the document.refer has a returnto URL in the query string, and easily exceeds uriMaxBytes. * I'm seeing the browser make beacon requests for the assign and impression reques, but not the submit event. * I really wish EventLogging would handle pre-defined built-in system fields for me like _user_anon_tk, etc. Change-Id: Ib650de386f9aa20ad31a9418acd48dceb84200b5 --- M Experiments.hooks.php M Experiments.php M experiments/acux/accountCreationUX.js A experiments/acux/dataModels.js 4 files changed, 136 insertions(+), 43 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/17/32017/1 -- To view, visit https://gerrit.wikimedia.org/r/32017 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib650de386f9aa20ad31a9418acd48dceb84200b5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage <sp...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
