[MediaWiki-commits] [Gerrit] Add X-WMF-UUID to Wikipedia for Android requests - change (apps...wikipedia)

2014-12-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add X-WMF-UUID to Wikipedia for Android requests
..


Add X-WMF-UUID to Wikipedia for Android requests

See also:
Ia0ab1691a31b9555721291803481104cb808689c

For now, the inclusion of the UUID in other places not to be removed.

On the Android it platform it seems that per-funnel identifiers
are part of the event data itself, and as with iOS, the UUID is
constructed in a reliable manner.

For now the goal is to ensure the goal is to ensure the presence
of the accurately set X-WMF-UUID header without causing other
unintended side effects in the app.

It should be possible to query request logs once this code and its
counterpart, in the following change

Ieeb3cc38e8d2f3244ec63d5345d4556e2f4a5df9

, are both deployed. If the values match when expected to match,
then it should be possible to remove the request path UUID in other
non-event payload contexts (e.g., PageViewFragmentInternal.java's
builder object with parameter "appInstallID").

Change-Id: I1f1cb4629cf7fe247f399a6d06feb7602ad0b455
---
M wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java 
b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
index 114dd70..5733bd7 100644
--- a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
@@ -277,6 +277,7 @@
 // 
https://lists.wikimedia.org/pipermail/wikimedia-l/2014-April/071131.html
 HashMap customHeaders = new HashMap();
 customHeaders.put("User-Agent", getUserAgent());
+customHeaders.put("X-WMF-UUID", getAppInstallID());
 String acceptLanguage = getAcceptLanguage();
 
 // TODO: once we're not constraining this to just Chinese, add the 
header unconditionally.

-- 
To view, visit https://gerrit.wikimedia.org/r/180868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f1cb4629cf7fe247f399a6d06feb7602ad0b455
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Deskana 
Gerrit-Reviewer: Dr0ptp4kt 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Nuria 
Gerrit-Reviewer: OliverKeyes 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add X-WMF-UUID to Wikipedia for Android requests - change (apps...wikipedia)

2014-12-18 Thread Dr0ptp4kt (Code Review) 
Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180868

Change subject: Add X-WMF-UUID to Wikipedia for Android requests
..

Add X-WMF-UUID to Wikipedia for Android requests

See also:
Ia0ab1691a31b9555721291803481104cb808689c

For now, the inclusion of the UUID in other places not to be removed.

On the Android it platform it seems that per-funnel identifiers
are part of the event data itself, and as with iOS, the UUID is
constructed in a reliable manner.

For now the goal is to ensure the goal is to ensure the presence
of the accurately set X-WMF-UUID header without causing other
unintended side effects in the app.

It should be possible to query request logs once this code and its
counterpart, in the following change

Ieeb3cc38e8d2f3244ec63d5345d4556e2f4a5df9

, are both deployed. If the values match when expected to match,
then it should be possible to remove the request path UUID in other
non-event payload contexts (e.g., PageViewFragmentInternal.java's
builder object with parameter "appInstallID").

Change-Id: I1f1cb4629cf7fe247f399a6d06feb7602ad0b455
---
M wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/68/180868/1

diff --git a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java 
b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
index 114dd70..7dd4f83 100644
--- a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
@@ -277,6 +277,7 @@
 // 
https://lists.wikimedia.org/pipermail/wikimedia-l/2014-April/071131.html
 HashMap customHeaders = new HashMap();
 customHeaders.put("User-Agent", getUserAgent());
+customHeaders.put("X-WMF-UUID", getAppInstallID() );
 String acceptLanguage = getAcceptLanguage();
 
 // TODO: once we're not constraining this to just Chinese, add the 
header unconditionally.

-- 
To view, visit https://gerrit.wikimedia.org/r/180868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f1cb4629cf7fe247f399a6d06feb7602ad0b455
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits