[MediaWiki-commits] [Gerrit] Add a type hint to RevDelList::setVisibility - change (mediawiki/core)

2016-04-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add a type hint to RevDelList::setVisibility
..


Add a type hint to RevDelList::setVisibility

Docblock mentions an array already. All usages in core I've managed
to track also pass in arrays.

Change-Id: I830f446a2b63d09c7aa81205d66ac56d8bdab733
---
M includes/revisiondelete/RevDelList.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/revisiondelete/RevDelList.php 
b/includes/revisiondelete/RevDelList.php
index 26e4b17..b92 100644
--- a/includes/revisiondelete/RevDelList.php
+++ b/includes/revisiondelete/RevDelList.php
@@ -103,7 +103,7 @@
 * @return Status
 * @since 1.23 Added 'perItemStatus' param
 */
-   public function setVisibility( $params ) {
+   public function setVisibility( array $params ) {
$bitPars = $params['value'];
$comment = $params['comment'];
$perItemStatus = isset( $params['perItemStatus'] ) ? 
$params['perItemStatus'] : false;

-- 
To view, visit https://gerrit.wikimedia.org/r/285652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I830f446a2b63d09c7aa81205d66ac56d8bdab733
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add a type hint to RevDelList::setVisibility - change (mediawiki/core)

2016-04-27 Thread WMDE-leszek (Code Review) 
WMDE-leszek has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/285652

Change subject: Add a type hint to RevDelList::setVisibility
..

Add a type hint to RevDelList::setVisibility

Docblock mentions an array already. All usages in core I've managed
to track also pass in arrays.

Change-Id: I830f446a2b63d09c7aa81205d66ac56d8bdab733
---
M includes/revisiondelete/RevDelList.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/52/285652/1

diff --git a/includes/revisiondelete/RevDelList.php 
b/includes/revisiondelete/RevDelList.php
index 26e4b17..b92 100644
--- a/includes/revisiondelete/RevDelList.php
+++ b/includes/revisiondelete/RevDelList.php
@@ -103,7 +103,7 @@
 * @return Status
 * @since 1.23 Added 'perItemStatus' param
 */
-   public function setVisibility( $params ) {
+   public function setVisibility( array $params ) {
$bitPars = $params['value'];
$comment = $params['comment'];
$perItemStatus = isset( $params['perItemStatus'] ) ? 
$params['perItemStatus'] : false;

-- 
To view, visit https://gerrit.wikimedia.org/r/285652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I830f446a2b63d09c7aa81205d66ac56d8bdab733
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits