[MediaWiki-commits] [Gerrit] Add basic Wikipedia Zero support for iOS. - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review) 
Brion VIBBER has submitted this change and it was merged.

Change subject: Add basic Wikipedia Zero support for iOS.
..


Add basic Wikipedia Zero support for iOS.

* Ready for review.
** Once toast/alert approach app-wide is determined, this code should use that 
approach.
** Once i18n approach resolved, this code will possibly need to be updated to 
reflect that.
** As production release nears, devmode option should be removed and listeners 
updated.
* The iOS version does not use a background process for monitoring radios. This 
isn't a music/nav app.

Change-Id: Ie15e3e7dcb955f4fad9fbe3ebe1ddcbebe8a7332
---
M Wikipedia-iOS.xcodeproj/project.pbxproj
M Wikipedia-iOS/AppDelegate.m
A Wikipedia-iOS/Data/Operations/DownloadWikipediaZeroMessageOp.h
A Wikipedia-iOS/Data/Operations/DownloadWikipediaZeroMessageOp.m
M Wikipedia-iOS/Queues/QueuesSingleton.h
M Wikipedia-iOS/Queues/QueuesSingleton.m
M Wikipedia-iOS/Session/SessionSingleton.h
M Wikipedia-iOS/Session/SessionSingleton.m
A Wikipedia-iOS/Settings.bundle/Root.plist
A Wikipedia-iOS/Settings.bundle/en.lproj/Root.strings
M Wikipedia-iOS/View Controllers/MainMenu/MainMenuTableViewController.m
M Wikipedia-iOS/View Controllers/TopNav/NavController.m
M Wikipedia-iOS/View Controllers/WebView/WebViewController.h
M Wikipedia-iOS/View Controllers/WebView/WebViewController.m
M Wikipedia-iOS/Web Image Interception/URLCache.m
A Wikipedia-iOS/Zero/ZeroConfigState.h
A Wikipedia-iOS/Zero/ZeroConfigState.m
M Wikipedia-iOS/en.lproj/Localizable.strings
A Wikipedia-iOS/mw-utils/WikipediaAppUtils.h
A Wikipedia-iOS/mw-utils/WikipediaAppUtils.m
20 files changed, 478 insertions(+), 5 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/Wikipedia-iOS.xcodeproj/project.pbxproj 
b/Wikipedia-iOS.xcodeproj/project.pbxproj
index f4fd217..51dc78e 100644
--- a/Wikipedia-iOS.xcodeproj/project.pbxproj
+++ b/Wikipedia-iOS.xcodeproj/project.pbxproj
@@ -238,6 +238,12 @@
04F39591186CF80100B0D6FC /* TOCViewController.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 04F3958F186CF80100B0D6FC /* TOCViewController.m 
*/; };
04FD6C7A184EBFCD002CA02F /* ArticleData.xcdatamodeld in Sources 
*/ = {isa = PBXBuildFile; fileRef = 04FD6C78184EBFCD002CA02F /* 
ArticleData.xcdatamodeld */; };
04FD6C7B184EBFCD002CA02F /* ArticleData.xcdatamodeld in Sources 
*/ = {isa = PBXBuildFile; fileRef = 04FD6C78184EBFCD002CA02F /* 
ArticleData.xcdatamodeld */; };
+   C9180EC418AED30C006C1DCA /* WikipediaAppUtils.m in Sources */ = 
{isa = PBXBuildFile; fileRef = C9180EC318AED30C006C1DCA /* WikipediaAppUtils.m 
*/; };
+   C9180EC518AED30C006C1DCA /* WikipediaAppUtils.m in Sources */ = 
{isa = PBXBuildFile; fileRef = C9180EC318AED30C006C1DCA /* WikipediaAppUtils.m 
*/; };
+   C9180EC918AED3B6006C1DCA /* ZeroConfigState.m in Sources */ = 
{isa = PBXBuildFile; fileRef = C9180EC818AED3B6006C1DCA /* ZeroConfigState.m 
*/; };
+   C9180ECA18AED3B6006C1DCA /* ZeroConfigState.m in Sources */ = 
{isa = PBXBuildFile; fileRef = C9180EC818AED3B6006C1DCA /* ZeroConfigState.m 
*/; };
+   C9928B8618AD5C6A00FCCA9A /* DownloadWikipediaZeroMessageOp.m in 
Sources */ = {isa = PBXBuildFile; fileRef = C9928B8518AD5C6A00FCCA9A /* 
DownloadWikipediaZeroMessageOp.m */; };
+   C9928B8818AD5E1000FCCA9A /* Settings.bundle in Resources */ = 
{isa = PBXBuildFile; fileRef = C9928B8718AD5E1000FCCA9A /* Settings.bundle */; 
};
D46CD8C418A1AC4F0042959E /* InfoPlist.strings in Resources */ = 
{isa = PBXBuildFile; fileRef = D46CD8C018A1AC4F0042959E /* InfoPlist.strings 
*/; };
D46CD8C518A1AC4F0042959E /* Localizable.strings in Resources */ 
= {isa = PBXBuildFile; fileRef = D46CD8C218A1AC4F0042959E /* 
Localizable.strings */; };
D474CC11182AE033002BDE45 /* SiteTests.m in Sources */ = {isa = 
PBXBuildFile; fileRef = D474CC10182AE033002BDE45 /* SiteTests.m */; };
@@ -469,6 +475,13 @@
04F3958E186CF80100B0D6FC /* TOCViewController.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
TOCViewController.h; sourceTree = group; };
04F3958F186CF80100B0D6FC /* TOCViewController.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= TOCViewController.m; sourceTree = group; };
04FD6C79184EBFCD002CA02F /* ArticleData.xcdatamodel */ = {isa = 
PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = 
ArticleData.xcdatamodel; sourceTree = group; };
+   C9180EC218AED30C006C1DCA /* WikipediaAppUtils.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
WikipediaAppUtils.h; sourceTree = group; };
+   C9180EC318AED30C006C1DCA /* WikipediaAppUtils.m */ = {isa = 
PBXFileReference; fileEncoding = 4;

[MediaWiki-commits] [Gerrit] Add basic Wikipedia Zero support for iOS. - change (apps...wikipedia)

2014-02-13 Thread Dr0ptp4kt (Code Review) 
Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/113176

Change subject: Add basic Wikipedia Zero support for iOS.
..

Add basic Wikipedia Zero support for iOS.

* Ready for review in order to get into mainline and avoid rebase druthers. 
However:
** Future separate patchset to have UI chrome color inversion across all 
screens instead of just search.
** Once toast/alert approach app-wide is determined, this code should use that 
approach.
** Once i18n approach resolved, this code will possibly need to be updated to 
reflect that.
** As production release nears, devmode option should be removed and listeners 
updated.
* The iOS version does not use a background process for monitoring radios. This 
isn't a music/nav app.

Change-Id: Ie15e3e7dcb955f4fad9fbe3ebe1ddcbebe8a7332
---
M Wikipedia-iOS.xcodeproj/project.pbxproj
M Wikipedia-iOS/AppDelegate.m
A Wikipedia-iOS/Data/Operations/DownloadWikipediaZeroMessageOp.h
A Wikipedia-iOS/Data/Operations/DownloadWikipediaZeroMessageOp.m
M Wikipedia-iOS/Queues/QueuesSingleton.h
M Wikipedia-iOS/Queues/QueuesSingleton.m
M Wikipedia-iOS/Session/SessionSingleton.h
M Wikipedia-iOS/Session/SessionSingleton.m
A Wikipedia-iOS/Settings.bundle/Root.plist
A Wikipedia-iOS/Settings.bundle/en.lproj/Root.strings
M Wikipedia-iOS/View Controllers/MainMenu/MainMenuTableViewController.m
M Wikipedia-iOS/View Controllers/TopNav/NavController.h
M Wikipedia-iOS/View Controllers/TopNav/NavController.m
M Wikipedia-iOS/View Controllers/WebView/WebViewController.h
M Wikipedia-iOS/View Controllers/WebView/WebViewController.m
M Wikipedia-iOS/Web Image Interception/URLCache.m
A Wikipedia-iOS/WikipediaAppUtils.h
A Wikipedia-iOS/WikipediaAppUtils.m
M Wikipedia-iOS/en.lproj/Localizable.strings
19 files changed, 460 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/76/113176/1

diff --git a/Wikipedia-iOS.xcodeproj/project.pbxproj 
b/Wikipedia-iOS.xcodeproj/project.pbxproj
index 9523cf5..4a8e311 100644
--- a/Wikipedia-iOS.xcodeproj/project.pbxproj
+++ b/Wikipedia-iOS.xcodeproj/project.pbxproj
@@ -230,6 +230,9 @@
04F39591186CF80100B0D6FC /* TOCViewController.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 04F3958F186CF80100B0D6FC /* TOCViewController.m 
*/; };
04FD6C7A184EBFCD002CA02F /* ArticleData.xcdatamodeld in Sources 
*/ = {isa = PBXBuildFile; fileRef = 04FD6C78184EBFCD002CA02F /* 
ArticleData.xcdatamodeld */; };
04FD6C7B184EBFCD002CA02F /* ArticleData.xcdatamodeld in Sources 
*/ = {isa = PBXBuildFile; fileRef = 04FD6C78184EBFCD002CA02F /* 
ArticleData.xcdatamodeld */; };
+   C9928B8618AD5C6A00FCCA9A /* DownloadWikipediaZeroMessageOp.m in 
Sources */ = {isa = PBXBuildFile; fileRef = C9928B8518AD5C6A00FCCA9A /* 
DownloadWikipediaZeroMessageOp.m */; };
+   C9928B8818AD5E1000FCCA9A /* Settings.bundle in Resources */ = 
{isa = PBXBuildFile; fileRef = C9928B8718AD5E1000FCCA9A /* Settings.bundle */; 
};
+   C9928B8C18AD641400FCCA9A /* WikipediaAppUtils.m in Sources */ = 
{isa = PBXBuildFile; fileRef = C9928B8B18AD641400FCCA9A /* WikipediaAppUtils.m 
*/; };
D46CD8C418A1AC4F0042959E /* InfoPlist.strings in Resources */ = 
{isa = PBXBuildFile; fileRef = D46CD8C018A1AC4F0042959E /* InfoPlist.strings 
*/; };
D46CD8C518A1AC4F0042959E /* Localizable.strings in Resources */ 
= {isa = PBXBuildFile; fileRef = D46CD8C218A1AC4F0042959E /* 
Localizable.strings */; };
D474CC11182AE033002BDE45 /* SiteTests.m in Sources */ = {isa = 
PBXBuildFile; fileRef = D474CC10182AE033002BDE45 /* SiteTests.m */; };
@@ -455,6 +458,11 @@
04F3958E186CF80100B0D6FC /* TOCViewController.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
TOCViewController.h; sourceTree = group; };
04F3958F186CF80100B0D6FC /* TOCViewController.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= TOCViewController.m; sourceTree = group; };
04FD6C79184EBFCD002CA02F /* ArticleData.xcdatamodel */ = {isa = 
PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = 
ArticleData.xcdatamodel; sourceTree = group; };
+   C9928B8418AD5C6A00FCCA9A /* DownloadWikipediaZeroMessageOp.h */ 
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.c.h; path = DownloadWikipediaZeroMessageOp.h; sourceTree = 
group; };
+   C9928B8518AD5C6A00FCCA9A /* DownloadWikipediaZeroMessageOp.m */ 
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.c.objc; path = DownloadWikipediaZeroMessageOp.m; sourceTree = 
group; };
+   C9928B8718AD5E1000FCCA9A /* Settings.bundle */ = {isa = 
PBXFileReference; lastKnownFileType = wrapper.plug-in; path = 
Settings.bundle; sourceTree =