[MediaWiki-commits] [Gerrit] Add "composer test" command for Jenkins - change (mediawiki...Wikibase)
Hoo man has submitted this change and it was merged. Change subject: Add "composer test" command for Jenkins .. Add "composer test" command for Jenkins Originally I copied this line from core. It used a parameter and you had to provide a directory when calling "composer phpcs .". Now the line is mostly copied from our Internal Serialization component. This allows to run "composer test" on Jenkins with no extra parameter. The order of the phpcs parameters follows the order given via "phpcs -?". Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 (cherry picked from commit 9573a10df3977328e70d7db852ba60257d79) --- M composer.json 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Hoo man: Verified; Looks good to me, approved diff --git a/composer.json b/composer.json index 2ed5674..34dc598 100644 --- a/composer.json +++ b/composer.json @@ -44,6 +44,9 @@ "diff/diff": "~2.0|~1.0" }, + "require-dev": { + "squizlabs/php_codesniffer": "~2.1" + }, "conflict": { "mediawiki/mediawiki": "<1.23" }, @@ -72,6 +75,9 @@ } }, "scripts": { - "phpcs": "phpcs $PHPCS_ARGS -s --standard=phpcs.xml --ignore=extensions/ValueView,vendor --encoding=utf-8 --extensions=php" + "test": [ + "composer phpcs" + ], + "phpcs": "vendor/bin/phpcs -sp --standard=phpcs.xml --extensions=php --ignore=extensions/ValueView,vendor ." } } -- To view, visit https://gerrit.wikimedia.org/r/220826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: wmf/1.26wmf9 Gerrit-Owner: Hoo man Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Legoktm Gerrit-Reviewer: Thiemo Mättig (WMDE) Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add "composer test" command for Jenkins - change (mediawiki...Wikibase)
Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/220826 Change subject: Add "composer test" command for Jenkins .. Add "composer test" command for Jenkins Originally I copied this line from core. It used a parameter and you had to provide a directory when calling "composer phpcs .". Now the line is mostly copied from our Internal Serialization component. This allows to run "composer test" on Jenkins with no extra parameter. The order of the phpcs parameters follows the order given via "phpcs -?". Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 (cherry picked from commit 9573a10df3977328e70d7db852ba60257d79) --- M composer.json 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/26/220826/1 diff --git a/composer.json b/composer.json index 2ed5674..34dc598 100644 --- a/composer.json +++ b/composer.json @@ -44,6 +44,9 @@ "diff/diff": "~2.0|~1.0" }, + "require-dev": { + "squizlabs/php_codesniffer": "~2.1" + }, "conflict": { "mediawiki/mediawiki": "<1.23" }, @@ -72,6 +75,9 @@ } }, "scripts": { - "phpcs": "phpcs $PHPCS_ARGS -s --standard=phpcs.xml --ignore=extensions/ValueView,vendor --encoding=utf-8 --extensions=php" + "test": [ + "composer phpcs" + ], + "phpcs": "vendor/bin/phpcs -sp --standard=phpcs.xml --extensions=php --ignore=extensions/ValueView,vendor ." } } -- To view, visit https://gerrit.wikimedia.org/r/220826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: wmf/1.26wmf9 Gerrit-Owner: Hoo man Gerrit-Reviewer: Thiemo Mättig (WMDE) ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add "composer test" command for Jenkins - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Add "composer test" command for Jenkins .. Add "composer test" command for Jenkins Originally I copied this line from core. It used a parameter and you had to provide a directory when calling "composer phpcs .". Now the line is mostly copied from our Internal Serialization component. This allows to run "composer test" on Jenkins with no extra parameter. The order of the phpcs parameters follows the order given via "phpcs -?". Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 --- M composer.json 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: JanZerebecki: Looks good to me, approved jenkins-bot: Verified diff --git a/composer.json b/composer.json index d1078ba..7794452 100644 --- a/composer.json +++ b/composer.json @@ -44,6 +44,9 @@ "diff/diff": "~2.0|~1.0" }, + "require-dev": { + "squizlabs/php_codesniffer": "~2.1" + }, "conflict": { "mediawiki/mediawiki": "<1.23" }, @@ -69,6 +72,9 @@ } }, "scripts": { - "phpcs": "phpcs $PHPCS_ARGS -s --standard=phpcs.xml --ignore=extensions/ValueView,vendor --encoding=utf-8 --extensions=php" + "test": [ + "composer phpcs" + ], + "phpcs": "vendor/bin/phpcs -sp --standard=phpcs.xml --extensions=php --ignore=extensions/ValueView,vendor ." } } -- To view, visit https://gerrit.wikimedia.org/r/220735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) Gerrit-Reviewer: JanZerebecki Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Legoktm Gerrit-Reviewer: Thiemo Mättig (WMDE) Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add "composer test" command for Jenkins - change (mediawiki...Wikibase)
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/220735 Change subject: Add "composer test" command for Jenkins .. Add "composer test" command for Jenkins Originally I copied this line from core. It used a parameter and you had to provide a directory when calling "composer phpcs .". Now the line is mostly copied from the Vector skin. This allows to run "composer test" on Jenkins with no extra parameter. The order of the phpcs parameters follows the order given via "phpcs -?". Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 --- M composer.json 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/35/220735/1 diff --git a/composer.json b/composer.json index d1078ba..f941eb4 100644 --- a/composer.json +++ b/composer.json @@ -69,6 +69,9 @@ } }, "scripts": { - "phpcs": "phpcs $PHPCS_ARGS -s --standard=phpcs.xml --ignore=extensions/ValueView,vendor --encoding=utf-8 --extensions=php" + "phpcs": "phpcs -sp --standard=phpcs.xml --extensions=php --ignore=extensions/ValueView,vendor .", + "test": [ + "composer phpcs" + ] } } -- To view, visit https://gerrit.wikimedia.org/r/220735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32e2e231521ac2f78aa9d08bb42c3dd37911e537 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits