[MediaWiki-commits] [Gerrit] Add description to MW/ruleset.xml - change (mediawiki...codesniffer)

2014-08-16 Thread Addshore (Code Review) 
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154403

Change subject: Add description to MW/ruleset.xml
..

Add description to MW/ruleset.xml

Change-Id: I651b6a86b753b60b842af15b61fa447a029a5edc
---
M MediaWiki/ruleset.xml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/03/154403/1

diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 7036716..c618405 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -7,6 +7,8 @@
 --
 ruleset name=MediaWiki
 
+   descriptionA coding standard for MediaWiki./description
+
rule ref=Generic.Classes.DuplicateClassName /
rule ref=Generic.CodeAnalysis.ForLoopShouldBeWhileLoop /
rule ref=Generic.CodeAnalysis.ForLoopWithTestFunctionCall /

-- 
To view, visit https://gerrit.wikimedia.org/r/154403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I651b6a86b753b60b842af15b61fa447a029a5edc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Addshore addshorew...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add description to MW/ruleset.xml - change (mediawiki...codesniffer)

2014-08-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add description to MW/ruleset.xml
..


Add description to MW/ruleset.xml

Change-Id: I651b6a86b753b60b842af15b61fa447a029a5edc
---
M MediaWiki/ruleset.xml
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 94fb91f..0c42d8a 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -6,6 +6,9 @@
- 
https://github.com/squizlabs/PHP_CodeSniffer/tree/master/CodeSniffer/Standards
 --
 ruleset name=MediaWiki
+
+   descriptionA coding standard for MediaWiki./description
+
rule ref=Generic.Classes.DuplicateClassName /
!-- Some people likes else { /** comment */ }
rule ref=Generic.CodeAnalysis.EmptyStatement /

-- 
To view, visit https://gerrit.wikimedia.org/r/154403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I651b6a86b753b60b842af15b61fa447a029a5edc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Addshore addshorew...@gmail.com
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits