[MediaWiki-commits] [Gerrit] Add exemption to the CVE linker for Ubuntu security links - change (wikimedia...modifications)

2014-02-14 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged.

Change subject: Add exemption to the CVE linker for Ubuntu security links
..


Add exemption to the CVE linker for Ubuntu security links

In an ideal world, there would be a more general solution to this
problem.  Rather than imagining all possible good and bad patterns,
let's just fix the error at hand for now.

Bug: 61328
Change-Id: I2429484d2523048194e27ba95100bcac1c6edf4a
---
M extensions/Wikimedia/Extension.pm
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Aklapper: Looks good to me, but someone else must approve
  Dzahn: Verified; Looks good to me, approved



diff --git a/extensions/Wikimedia/Extension.pm 
b/extensions/Wikimedia/Extension.pm
index c75722d..2f1c306 100644
--- a/extensions/Wikimedia/Extension.pm
+++ b/extensions/Wikimedia/Extension.pm
@@ -68,8 +68,9 @@
replace => \&_createGitCommitLink
};
 
+   # Test case: https://bugzilla.wikimedia.org/60112#c8
my $replacerCVE = {
-   match => qr{\b(CVE-\d{4}-\d+)},
+   match => 
qr{(?http://people\.canonical\.com/~ubuntu-security/cve/2013/)\b(CVE-\d{4}-\d+)},
replace => \&_createCVELink
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/113170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2429484d2523048194e27ba95100bcac1c6edf4a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Aklapper 
Gerrit-Reviewer: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add exemption to the CVE linker for Ubuntu security links - change (wikimedia...modifications)

2014-02-13 Thread Tim Landscheidt (Code Review) 
Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/113170

Change subject: Add exemption to the CVE linker for Ubuntu security links
..

Add exemption to the CVE linker for Ubuntu security links

In an ideal world, there would be a more general solution to this
problem.  Rather than imagining all possible good and bad patterns,
let's just fix the error at hand for now.

Bug: 61328
Change-Id: I2429484d2523048194e27ba95100bcac1c6edf4a
---
M extensions/Wikimedia/Extension.pm
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/modifications 
refs/changes/70/113170/1

diff --git a/extensions/Wikimedia/Extension.pm 
b/extensions/Wikimedia/Extension.pm
index c75722d..2f1c306 100644
--- a/extensions/Wikimedia/Extension.pm
+++ b/extensions/Wikimedia/Extension.pm
@@ -68,8 +68,9 @@
replace => \&_createGitCommitLink
};
 
+   # Test case: https://bugzilla.wikimedia.org/60112#c8
my $replacerCVE = {
-   match => qr{\b(CVE-\d{4}-\d+)},
+   match => 
qr{(?http://people\.canonical\.com/~ubuntu-security/cve/2013/)\b(CVE-\d{4}-\d+)},
replace => \&_createCVELink
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/113170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2429484d2523048194e27ba95100bcac1c6edf4a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits