[MediaWiki-commits] [Gerrit] Add missing @throws tag - change (mediawiki...CentralAuth)

2014-10-26 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168918

Change subject: Add missing @throws tag
..

Add missing @throws tag

Change-Id: Ib278acc8181c3a35368ef858b72133786aba94e5
---
M includes/GlobalRename/GlobalRenameRequest.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/18/168918/1

diff --git a/includes/GlobalRename/GlobalRenameRequest.php 
b/includes/GlobalRename/GlobalRenameRequest.php
index aeeb8e2..b839a4c 100644
--- a/includes/GlobalRename/GlobalRenameRequest.php
+++ b/includes/GlobalRename/GlobalRenameRequest.php
@@ -140,6 +140,7 @@
 
/**
 * @param string $newName
+* @throws MWException if an invalid username is provided
 * @return GlobalRenameRequest self, for message chaining
 */
public function setNewName( $newName ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/168918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib278acc8181c3a35368ef858b72133786aba94e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add missing @throws tag - change (mediawiki...CentralAuth)

2014-10-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add missing @throws tag
..


Add missing @throws tag

Change-Id: Ib278acc8181c3a35368ef858b72133786aba94e5
---
M includes/GlobalRename/GlobalRenameRequest.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/GlobalRename/GlobalRenameRequest.php 
b/includes/GlobalRename/GlobalRenameRequest.php
index aeeb8e2..b839a4c 100644
--- a/includes/GlobalRename/GlobalRenameRequest.php
+++ b/includes/GlobalRename/GlobalRenameRequest.php
@@ -140,6 +140,7 @@
 
/**
 * @param string $newName
+* @throws MWException if an invalid username is provided
 * @return GlobalRenameRequest self, for message chaining
 */
public function setNewName( $newName ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/168918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib278acc8181c3a35368ef858b72133786aba94e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Hoo man h...@online.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits