[MediaWiki-commits] [Gerrit] Add missing ) on line 131 - change (mediawiki...Sudo)

2016-07-03 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Add missing ) on line 131
..


Add missing ) on line 131

Follow up: Ifddcebbc7681054770600bd28e14e1ba968ba97d

Bug: T139235
Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
---
M SpecialSudo.php
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Kghbln: Looks good to me, but someone else must approve
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialSudo.php b/SpecialSudo.php
index 3e9165e..b987701 100644
--- a/SpecialSudo.php
+++ b/SpecialSudo.php
@@ -127,10 +127,9 @@
$wgOut->addHTML(
$this->msg( 'sudo-unsudo' )
->rawParams( Linker::link( 
$suUser->getUserPage(), htmlspecialchars( $suUser->getName() ) ) )
-   ->rawParams (Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) )
+   ->rawParams( Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) ) )
->params( $wgUser->getName() )
-   ->parse()
-   ) .
+   ->parse() .
Xml::submitButton( $this->msg( 
'sudo-unsudo-submit' )->text() ) .
Xml::closeElement( 'form' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/297130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Sudo
Gerrit-Branch: REL1_27
Gerrit-Owner: Paladox 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Daniel Friesen 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: JanZerebecki 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Kghbln 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add missing ) on line 131 - change (mediawiki...Sudo)

2016-07-03 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Add missing ) on line 131
..


Add missing ) on line 131

Follow up: Ifddcebbc7681054770600bd28e14e1ba968ba97d

Bug: T139235
Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
---
M SpecialSudo.php
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Kghbln: Looks good to me, but someone else must approve
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialSudo.php b/SpecialSudo.php
index 3e9165e..b987701 100644
--- a/SpecialSudo.php
+++ b/SpecialSudo.php
@@ -127,10 +127,9 @@
$wgOut->addHTML(
$this->msg( 'sudo-unsudo' )
->rawParams( Linker::link( 
$suUser->getUserPage(), htmlspecialchars( $suUser->getName() ) ) )
-   ->rawParams (Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) )
+   ->rawParams( Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) ) )
->params( $wgUser->getName() )
-   ->parse()
-   ) .
+   ->parse() .
Xml::submitButton( $this->msg( 
'sudo-unsudo-submit' )->text() ) .
Xml::closeElement( 'form' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/297128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Sudo
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Daniel Friesen 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Kghbln 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add missing ) on line 131 - change (mediawiki...Sudo)

2016-07-02 Thread Paladox (Code Review)
Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/297130

Change subject: Add missing ) on line 131
..

Add missing ) on line 131

Bug: T139235
Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
---
M SpecialSudo.php
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Sudo 
refs/changes/30/297130/1

diff --git a/SpecialSudo.php b/SpecialSudo.php
index 3e9165e..b987701 100644
--- a/SpecialSudo.php
+++ b/SpecialSudo.php
@@ -127,10 +127,9 @@
$wgOut->addHTML(
$this->msg( 'sudo-unsudo' )
->rawParams( Linker::link( 
$suUser->getUserPage(), htmlspecialchars( $suUser->getName() ) ) )
-   ->rawParams (Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) )
+   ->rawParams( Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) ) )
->params( $wgUser->getName() )
-   ->parse()
-   ) .
+   ->parse() .
Xml::submitButton( $this->msg( 
'sudo-unsudo-submit' )->text() ) .
Xml::closeElement( 'form' )
);

-- 
To view, visit https://gerrit.wikimedia.org/r/297130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Sudo
Gerrit-Branch: REL1_27
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add missing ) on line 131 - change (mediawiki...Sudo)

2016-07-02 Thread Paladox (Code Review)
Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/297128

Change subject: Add missing ) on line 131
..

Add missing ) on line 131

Bug: T139235
Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
---
M SpecialSudo.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Sudo 
refs/changes/28/297128/1

diff --git a/SpecialSudo.php b/SpecialSudo.php
index 3e9165e..ddd1005 100644
--- a/SpecialSudo.php
+++ b/SpecialSudo.php
@@ -127,7 +127,7 @@
$wgOut->addHTML(
$this->msg( 'sudo-unsudo' )
->rawParams( Linker::link( 
$suUser->getUserPage(), htmlspecialchars( $suUser->getName() ) ) )
-   ->rawParams (Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) )
+   ->rawParams(Linker::link( 
$wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) ) )
->params( $wgUser->getName() )
->parse()
) .

-- 
To view, visit https://gerrit.wikimedia.org/r/297128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a5d647fb1eb8be302a4e43ec28044dc48d34a8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Sudo
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits