[MediaWiki-commits] [Gerrit] Add missing return value for DatabaseBase::open() overrides - change (mediawiki/core)

2013-12-27 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/104055


Change subject: Add missing return value for DatabaseBase::open() overrides
..

Add missing return value for DatabaseBase::open() overrides

Change-Id: Ifcd9e6fb36a5f8f53ad38a60719267d69c86c17e
---
M includes/db/DatabaseMssql.php
M includes/db/DatabaseOracle.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/55/104055/1

diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index 5a5eab1..49b0121 100644
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -88,7 +88,7 @@
 
# e.g. the class is being loaded
if ( !strlen( $user ) ) {
-   return;
+   return null;
}
 
$this-close();
diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index 10715e4..0619fd6 100644
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -302,7 +302,7 @@
}
 
if ( !strlen( $user ) ) { # e.g. the class is being loaded
-   return;
+   return null;
}
 
if ( $wgDBOracleDRCP ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/104055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcd9e6fb36a5f8f53ad38a60719267d69c86c17e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add missing return value for DatabaseBase::open() overrides - change (mediawiki/core)

2013-12-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add missing return value for DatabaseBase::open() overrides
..


Add missing return value for DatabaseBase::open() overrides

Change-Id: Ifcd9e6fb36a5f8f53ad38a60719267d69c86c17e
---
M includes/db/DatabaseMssql.php
M includes/db/DatabaseOracle.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index 5a5eab1..49b0121 100644
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -88,7 +88,7 @@
 
# e.g. the class is being loaded
if ( !strlen( $user ) ) {
-   return;
+   return null;
}
 
$this-close();
diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index 10715e4..0619fd6 100644
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -302,7 +302,7 @@
}
 
if ( !strlen( $user ) ) { # e.g. the class is being loaded
-   return;
+   return null;
}
 
if ( $wgDBOracleDRCP ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/104055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcd9e6fb36a5f8f53ad38a60719267d69c86c17e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Parent5446 tylerro...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits