[MediaWiki-commits] [Gerrit] Add missing visualClear on search result page - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Add missing visualClear on search result page .. Add missing visualClear on search result page I'm not sure, when this was removed or why it broke, but without the visualClear (clear:both), the text match section is near the title match section, instead of after it. Bug: T133071 Change-Id: I68028a8658ba0aa526ce1a6ef6401f9fd79533f8 --- M includes/specials/SpecialSearch.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php old mode 100644 new mode 100755 index 45ef679..2bf8385 --- a/includes/specials/SpecialSearch.php +++ b/includes/specials/SpecialSearch.php @@ -376,6 +376,7 @@ if ( $textMatches && !$textStatus ) { // output appropriate heading if ( $numTextMatches > 0 && $numTitleMatches > 0 ) { + $out->addHTML( '' ); // if no title matches the heading is redundant $out->wrapWikiMsg( "==$1==\n", 'textmatches' ); } -- To view, visit https://gerrit.wikimedia.org/r/284236 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68028a8658ba0aa526ce1a6ef6401f9fd79533f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: FlorianschmidtwelzowGerrit-Reviewer: Bartosz Dziewoński Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing visualClear on search result page - change (mediawiki/core)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/284236 Change subject: Add missing visualClear on search result page .. Add missing visualClear on search result page I'm not sure, when this was removed or why it broke, but without the visualClear (clear:both), the text match section is near the title match section, instead of after it. Bug: T133071 Change-Id: I68028a8658ba0aa526ce1a6ef6401f9fd79533f8 --- M includes/specials/SpecialSearch.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/36/284236/1 diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php old mode 100644 new mode 100755 index 45ef679..2bf8385 --- a/includes/specials/SpecialSearch.php +++ b/includes/specials/SpecialSearch.php @@ -376,6 +376,7 @@ if ( $textMatches && !$textStatus ) { // output appropriate heading if ( $numTextMatches > 0 && $numTitleMatches > 0 ) { + $out->addHTML( '' ); // if no title matches the heading is redundant $out->wrapWikiMsg( "==$1==\n", 'textmatches' ); } -- To view, visit https://gerrit.wikimedia.org/r/284236 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68028a8658ba0aa526ce1a6ef6401f9fd79533f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits