[MediaWiki-commits] [Gerrit] Add print styles, add 'mw' to page-header-links id - change (mediawiki...Timeless)
jenkins-bot has submitted this change and it was merged. Change subject: Add print styles, add 'mw' to page-header-links id .. Add print styles, add 'mw' to page-header-links id Bug: T131987 Change-Id: Ia14e7f26dd249e95d1bbe00437b8d1483be08fa5 --- M TimelessTemplate.php A resources/print.css M resources/screen-common.less M resources/screen-desktop.less M skin.json 5 files changed, 23 insertions(+), 4 deletions(-) Approvals: Isarra: Looks good to me, approved jenkins-bot: Verified diff --git a/TimelessTemplate.php b/TimelessTemplate.php index d628fbb..90ff543 100644 --- a/TimelessTemplate.php +++ b/TimelessTemplate.php @@ -107,7 +107,7 @@ html( 'title' ) ?> - + assemblePortlet( array( 'id' => 'p-namespaces', diff --git a/resources/print.css b/resources/print.css new file mode 100644 index 000..cc8f611 --- /dev/null +++ b/resources/print.css @@ -0,0 +1,16 @@ +/* Styles for print view and printing */ + +/* Hide some extra stuff from print view */ +.mw-indicators, +#mw-header, +#mw-site-navigation, +#mw-related-navigation, +#mw-page-header-links, +#mw-footer, +#catlinks { + display: none; +} + +#mw-content-text { + margin-bottom: 3em; +} diff --git a/resources/screen-common.less b/resources/screen-common.less index cc66e55..4ea5124 100644 --- a/resources/screen-common.less +++ b/resources/screen-common.less @@ -165,7 +165,7 @@ #mw-content-container { border-bottom: solid 4px @green; } -#page-header-links { +#mw-page-header-links { div, ul, li { diff --git a/resources/screen-desktop.less b/resources/screen-desktop.less index 8be7343..d9523ce 100644 --- a/resources/screen-desktop.less +++ b/resources/screen-desktop.less @@ -101,8 +101,8 @@ } } -#page-header-links #ca-more, -#page-header-links #ca-languages, +#mw-page-header-links #ca-more, +#mw-page-header-links #ca-languages, .sidebar-chunk h2 { display: none; } diff --git a/skin.json b/skin.json index 6b0e276..cf38d28 100644 --- a/skin.json +++ b/skin.json @@ -43,6 +43,9 @@ }, "resources/screen-mobile.less": { "media": "screen and (max-width: 850px)" + }, + "resources/print.css": { + "media": "print" } } }, -- To view, visit https://gerrit.wikimedia.org/r/282480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia14e7f26dd249e95d1bbe00437b8d1483be08fa5 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/skins/Timeless Gerrit-Branch: master Gerrit-Owner: Isarra Gerrit-Reviewer: Isarra Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add print styles, add 'mw' to page-header-links id - change (mediawiki...Timeless)
Isarra has uploaded a new change for review. https://gerrit.wikimedia.org/r/282480 Change subject: Add print styles, add 'mw' to page-header-links id .. Add print styles, add 'mw' to page-header-links id Change-Id: Ia14e7f26dd249e95d1bbe00437b8d1483be08fa5 --- M TimelessTemplate.php A resources/print.css M resources/screen-common.less M resources/screen-desktop.less M skin.json 5 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless refs/changes/80/282480/1 diff --git a/TimelessTemplate.php b/TimelessTemplate.php index d628fbb..90ff543 100644 --- a/TimelessTemplate.php +++ b/TimelessTemplate.php @@ -107,7 +107,7 @@ html( 'title' ) ?> - + assemblePortlet( array( 'id' => 'p-namespaces', diff --git a/resources/print.css b/resources/print.css new file mode 100644 index 000..cc8f611 --- /dev/null +++ b/resources/print.css @@ -0,0 +1,16 @@ +/* Styles for print view and printing */ + +/* Hide some extra stuff from print view */ +.mw-indicators, +#mw-header, +#mw-site-navigation, +#mw-related-navigation, +#mw-page-header-links, +#mw-footer, +#catlinks { + display: none; +} + +#mw-content-text { + margin-bottom: 3em; +} diff --git a/resources/screen-common.less b/resources/screen-common.less index cc66e55..4ea5124 100644 --- a/resources/screen-common.less +++ b/resources/screen-common.less @@ -165,7 +165,7 @@ #mw-content-container { border-bottom: solid 4px @green; } -#page-header-links { +#mw-page-header-links { div, ul, li { diff --git a/resources/screen-desktop.less b/resources/screen-desktop.less index 8be7343..d9523ce 100644 --- a/resources/screen-desktop.less +++ b/resources/screen-desktop.less @@ -101,8 +101,8 @@ } } -#page-header-links #ca-more, -#page-header-links #ca-languages, +#mw-page-header-links #ca-more, +#mw-page-header-links #ca-languages, .sidebar-chunk h2 { display: none; } diff --git a/skin.json b/skin.json index 6b0e276..cf38d28 100644 --- a/skin.json +++ b/skin.json @@ -43,6 +43,9 @@ }, "resources/screen-mobile.less": { "media": "screen and (max-width: 850px)" + }, + "resources/print.css": { + "media": "print" } } }, -- To view, visit https://gerrit.wikimedia.org/r/282480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia14e7f26dd249e95d1bbe00437b8d1483be08fa5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Timeless Gerrit-Branch: master Gerrit-Owner: Isarra ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits