[MediaWiki-commits] [Gerrit] Add various missing htmlspecialchars() calls to EntityView. - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Add various missing htmlspecialchars() calls to EntityView. .. Add various missing htmlspecialchars() calls to EntityView. Bug: 53472 Change-Id: I0d874df9b02e457f4691accd7d29edf6c58f0ea5 --- M repo/includes/EntityView.php 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php index e5a0adc..da5c3b9 100644 --- a/repo/includes/EntityView.php +++ b/repo/includes/EntityView.php @@ -336,7 +336,7 @@ $prefixedId, wfTemplate( 'wb-property', $label === false ? 'wb-value-empty' : '', - $label === false ? wfMessage( 'wikibase-label-empty' )-text() : htmlspecialchars( $label ), + htmlspecialchars( $label === false ? wfMessage( 'wikibase-label-empty' )-text() : $label ), $this-getHtmlForEditSection( $entity, $lang, $editUrl ) ) ); @@ -368,7 +368,7 @@ $html = wfTemplate( 'wb-description', wfTemplate( 'wb-property', $description === false ? 'wb-value-empty' : '', - $description === false ? wfMessage( 'wikibase-description-empty' )-text() : htmlspecialchars( $description ), + htmlspecialchars( $description === false ? wfMessage( 'wikibase-description-empty' )-text() : $description ), $this-getHtmlForEditSection( $entity, $lang, $editUrl ) ) ); @@ -506,9 +506,9 @@ $tbody .= wfTemplate( 'wb-term', $language, $alternatingClass, - Utils::fetchLanguageName( $language ), - $label !== false ? $label : wfMessage( 'wikibase-label-empty' ), - $description !== false ? $description : wfMessage( 'wikibase-description-empty' ), + htmlspecialchars( Utils::fetchLanguageName( $language ) ), + htmlspecialchars( $label !== false ? $label : wfMessage( 'wikibase-label-empty' ) ), + htmlspecialchars( $description !== false ? $description : wfMessage( 'wikibase-description-empty' ) ), $this-getHtmlForEditSection( $entity, $lang, $editLabelLink ), $this-getHtmlForEditSection( $entity, $lang, $editDescriptionLink ), $label !== false ? '' : 'wb-value-empty', -- To view, visit https://gerrit.wikimedia.org/r/81566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d874df9b02e457f4691accd7d29edf6c58f0ea5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Liangent liang...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add various missing htmlspecialchars() calls to EntityView. - change (mediawiki...Wikibase)
Liangent has uploaded a new change for review. https://gerrit.wikimedia.org/r/81566 Change subject: Add various missing htmlspecialchars() calls to EntityView. .. Add various missing htmlspecialchars() calls to EntityView. Bug: 53472 Change-Id: I0d874df9b02e457f4691accd7d29edf6c58f0ea5 --- M repo/includes/EntityView.php 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/66/81566/1 diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php index e5a0adc..da5c3b9 100644 --- a/repo/includes/EntityView.php +++ b/repo/includes/EntityView.php @@ -336,7 +336,7 @@ $prefixedId, wfTemplate( 'wb-property', $label === false ? 'wb-value-empty' : '', - $label === false ? wfMessage( 'wikibase-label-empty' )-text() : htmlspecialchars( $label ), + htmlspecialchars( $label === false ? wfMessage( 'wikibase-label-empty' )-text() : $label ), $this-getHtmlForEditSection( $entity, $lang, $editUrl ) ) ); @@ -368,7 +368,7 @@ $html = wfTemplate( 'wb-description', wfTemplate( 'wb-property', $description === false ? 'wb-value-empty' : '', - $description === false ? wfMessage( 'wikibase-description-empty' )-text() : htmlspecialchars( $description ), + htmlspecialchars( $description === false ? wfMessage( 'wikibase-description-empty' )-text() : $description ), $this-getHtmlForEditSection( $entity, $lang, $editUrl ) ) ); @@ -506,9 +506,9 @@ $tbody .= wfTemplate( 'wb-term', $language, $alternatingClass, - Utils::fetchLanguageName( $language ), - $label !== false ? $label : wfMessage( 'wikibase-label-empty' ), - $description !== false ? $description : wfMessage( 'wikibase-description-empty' ), + htmlspecialchars( Utils::fetchLanguageName( $language ) ), + htmlspecialchars( $label !== false ? $label : wfMessage( 'wikibase-label-empty' ) ), + htmlspecialchars( $description !== false ? $description : wfMessage( 'wikibase-description-empty' ) ), $this-getHtmlForEditSection( $entity, $lang, $editLabelLink ), $this-getHtmlForEditSection( $entity, $lang, $editDescriptionLink ), $label !== false ? '' : 'wb-value-empty', -- To view, visit https://gerrit.wikimedia.org/r/81566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d874df9b02e457f4691accd7d29edf6c58f0ea5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Liangent liang...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
