[MediaWiki-commits] [Gerrit] Adjust arrow styles - change (mediawiki...RevisionSlider)
jenkins-bot has submitted this change and it was merged.
Change subject: Adjust arrow styles
..
Adjust arrow styles
This introduces styles for "not available" arrow, and styles for hovered arrow
and "active" (under left mouse button click arrow).
Bug: T135970
Change-Id: If5f7df475eef36dcb6d038297ad97717b8c96f77
---
M extension.json
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
A resources/ext.RevisionSlider.arrows/arrow-left-disabled.svg
A resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg
A resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg
A resources/ext.RevisionSlider.arrows/arrow-right-disabled.svg
A resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg
A resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg
9 files changed, 115 insertions(+), 19 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index e1e92ef..61d1867 100755
--- a/extension.json
+++ b/extension.json
@@ -28,11 +28,12 @@
],
"dependencies": [
"mediawiki.jqueryMsg",
- "oojs-ui.styles.icons-movement",
"ext.RevisionSlider.Slider",
"ext.RevisionSlider.Revision",
"ext.RevisionSlider.RevisionList",
"ext.RevisionSlider.fetchRevisions",
+ "ext.RevisionSlider.arrows.left",
+ "ext.RevisionSlider.arrows.right",
"ext.RevisionSlider.pointers.lower",
"ext.RevisionSlider.pointers.upper"
],
@@ -114,6 +115,26 @@
"revisionslider-label-comment"
]
},
+ "ext.RevisionSlider.arrows.left": {
+ "position": "top",
+ "class": "ResourceLoaderImageModule",
+ "selector": ".arrow-left.arrow-{name}",
+ "images": {
+ "enabled":
"resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg",
+ "hovered":
"resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg",
+ "disabled":
"resources/ext.RevisionSlider.arrows/arrow-left-disabled.svg"
+ }
+ },
+ "ext.RevisionSlider.arrows.right": {
+ "position": "top",
+ "class": "ResourceLoaderImageModule",
+ "selector": ".arrow-right.arrow-{name}",
+ "images": {
+ "enabled":
"resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg",
+ "hovered":
"resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg",
+ "disabled":
"resources/ext.RevisionSlider.arrows/arrow-right-disabled.svg"
+ }
+ },
"ext.RevisionSlider.pointers.lower": {
"position": "top",
"class": "ResourceLoaderImageModule",
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 76a4f53..2e2fcdc 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -47,8 +47,15 @@
width: ( containerWidth +
this.containerMargin ) + 'px'
} )
.append(
- $( '' )
- .tipsy()
+ $( '' )
+ .tipsy( {
+ title: function () {
+ if ( $( this
).hasClass( 'arrow-disabled' ) ) {
+ return '';
+ }
+ return mw.message(
'revisionslider-arrow-tooltip-older' ).text();
+ }
+ } )
)
.append( $( '' )
.css( {
@@ -56,10 +63,16 @@
} )
.append( $revisions ) )
.append(
- $( '' )
+ $( '' )
[MediaWiki-commits] [Gerrit] Adjust arrow styles - change (mediawiki...RevisionSlider)
WMDE-leszek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291241
Change subject: Adjust arrow styles
..
Adjust arrow styles
This introduces styles for "not available" arrow, and styles for hovered arrow
and "active" (under left mouse button click arrow).
Bug: T135970
Change-Id: If5f7df475eef36dcb6d038297ad97717b8c96f77
---
M extension.json
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
A resources/ext.RevisionSlider.arrows/arrow-left-disabled.svg
A resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg
A resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg
A resources/ext.RevisionSlider.arrows/arrow-right-disabled.svg
A resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg
A resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg
9 files changed, 113 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/41/291241/1
diff --git a/extension.json b/extension.json
index e1e92ef..61d1867 100755
--- a/extension.json
+++ b/extension.json
@@ -28,11 +28,12 @@
],
"dependencies": [
"mediawiki.jqueryMsg",
- "oojs-ui.styles.icons-movement",
"ext.RevisionSlider.Slider",
"ext.RevisionSlider.Revision",
"ext.RevisionSlider.RevisionList",
"ext.RevisionSlider.fetchRevisions",
+ "ext.RevisionSlider.arrows.left",
+ "ext.RevisionSlider.arrows.right",
"ext.RevisionSlider.pointers.lower",
"ext.RevisionSlider.pointers.upper"
],
@@ -114,6 +115,26 @@
"revisionslider-label-comment"
]
},
+ "ext.RevisionSlider.arrows.left": {
+ "position": "top",
+ "class": "ResourceLoaderImageModule",
+ "selector": ".arrow-left.arrow-{name}",
+ "images": {
+ "enabled":
"resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg",
+ "hovered":
"resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg",
+ "disabled":
"resources/ext.RevisionSlider.arrows/arrow-left-disabled.svg"
+ }
+ },
+ "ext.RevisionSlider.arrows.right": {
+ "position": "top",
+ "class": "ResourceLoaderImageModule",
+ "selector": ".arrow-right.arrow-{name}",
+ "images": {
+ "enabled":
"resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg",
+ "hovered":
"resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg",
+ "disabled":
"resources/ext.RevisionSlider.arrows/arrow-right-disabled.svg"
+ }
+ },
"ext.RevisionSlider.pointers.lower": {
"position": "top",
"class": "ResourceLoaderImageModule",
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 76a4f53..4e22cd7 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -47,8 +47,15 @@
width: ( containerWidth +
this.containerMargin ) + 'px'
} )
.append(
- $( '' )
- .tipsy()
+ $( '' )
+ .tipsy( {
+ title: function () {
+ if ( $( this
).hasClass( 'arrow-disabled' ) ) {
+ return '';
+ }
+ return mw.message(
'revisionslider-arrow-tooltip-older' ).text();
+ }
+ } )
)
.append( $( '' )
.css( {
@@ -56,10 +63,16 @@
} )
.append( $revisions ) )
.append(
- $( '' )
+ $( '' )
