[MediaWiki-commits] [Gerrit] Allow toggling elements with space - change (mediawiki/core)

2013-09-07 Thread Hoo man (Code Review) 
Hoo man has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/83226


Change subject: Allow toggling elements with space
..

Allow toggling elements with space

This seems more convenient than having the space key
do nothing as it does right now.
Furthermore this is more consistent with the various
other collapsible things we have around than to just
scroll the page on a space keypress.

Bug: 53797
Change-Id: If9292ef6a8fd82b097c597dc166e38c8ca31f4ff
---
M resources/jquery/jquery.makeCollapsible.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/26/83226/1

diff --git a/resources/jquery/jquery.makeCollapsible.js 
b/resources/jquery/jquery.makeCollapsible.js
index ac46092..27c4c6c 100644
--- a/resources/jquery/jquery.makeCollapsible.js
+++ b/resources/jquery/jquery.makeCollapsible.js
@@ -163,8 +163,8 @@
if ( e.type === 'click'  options.linksPassthru  
$.nodeName( e.target, 'a' ) ) {
// Don't fire if a link was clicked, if 
requested  (for premade togglers by default)
return;
-   } else if ( e.type === 'keypress'  e.which !== 13 ) {
-   // Only handle keypresses on the Enter key
+   } else if ( e.type === 'keypress'  e.which !== 13  
e.which !== 32 ) {
+   // Only handle keypresses on the Enter or 
Space keys
return;
} else {
e.preventDefault();

-- 
To view, visit https://gerrit.wikimedia.org/r/83226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9292ef6a8fd82b097c597dc166e38c8ca31f4ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man h...@online.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Allow toggling elements with space - change (mediawiki/core)

2013-09-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Allow toggling elements with space
..


Allow toggling elements with space

This seems more convenient than having the space key
do nothing as it does right now.
Furthermore this is more consistent with the various
other collapsible things we have around than to just
scroll the page on a space keypress.

Bug: 53797
Change-Id: If9292ef6a8fd82b097c597dc166e38c8ca31f4ff
---
M resources/jquery/jquery.makeCollapsible.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/jquery/jquery.makeCollapsible.js 
b/resources/jquery/jquery.makeCollapsible.js
index ac46092..27c4c6c 100644
--- a/resources/jquery/jquery.makeCollapsible.js
+++ b/resources/jquery/jquery.makeCollapsible.js
@@ -163,8 +163,8 @@
if ( e.type === 'click'  options.linksPassthru  
$.nodeName( e.target, 'a' ) ) {
// Don't fire if a link was clicked, if 
requested  (for premade togglers by default)
return;
-   } else if ( e.type === 'keypress'  e.which !== 13 ) {
-   // Only handle keypresses on the Enter key
+   } else if ( e.type === 'keypress'  e.which !== 13  
e.which !== 32 ) {
+   // Only handle keypresses on the Enter or 
Space keys
return;
} else {
e.preventDefault();

-- 
To view, visit https://gerrit.wikimedia.org/r/83226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9292ef6a8fd82b097c597dc166e38c8ca31f4ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man h...@online.de
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Jack Phoenix j...@countervandalism.net
Gerrit-Reviewer: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits