[MediaWiki-commits] [Gerrit] Apply number formatting on new stats design - change (mediawiki...ContentTranslation)
jenkins-bot has submitted this change and it was merged.
Change subject: Apply number formatting on new stats design
..
Apply number formatting on new stats design
Change-Id: I690d62b28338e6279b099db3f5295d82d7a5fdb7
---
M modules/stats/ext.cx.stats.js
1 file changed, 50 insertions(+), 19 deletions(-)
Approvals:
KartikMistry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/stats/ext.cx.stats.js b/modules/stats/ext.cx.stats.js
index f150023..8a8ddcd 100644
--- a/modules/stats/ext.cx.stats.js
+++ b/modules/stats/ext.cx.stats.js
@@ -69,7 +69,8 @@
lastWeekTotal, lastWeekLangTotal, weekTrend = 0,
weekLangTrend = 0,
lastWeekLangTranslations, prevWeekLangTotal,
lastWeekTranslations,
- prevWeekTotal, prevWeekTranslations,
prevWeekLangTranslations;
+ prevWeekTotal, prevWeekTranslations,
prevWeekLangTranslations,
+ fmt = mw.language.convertNumber;
if ( this.totalTranslationTrend.length 3 ) {
// Trend calculation works if we have enough data
@@ -104,25 +105,44 @@
$total = $( 'div' )
.addClass( 'cx-stats-box' )
.append(
- $( 'div' ).addClass( 'cx-stats-box__title'
).text( mw.msg( 'cx-stats-total-published' ) ),
- $( 'div' ).addClass( 'cx-stats-box__total'
).text( total ),
- $( 'div' ).addClass(
'cx-stats-box__localtotal' )
- .text( mw.msg( 'cx-stats-local-published',
langTotal, localLanguage ) )
+ $( 'div' )
+ .addClass( 'cx-stats-box__title' )
+ .text( mw.msg(
'cx-stats-total-published' ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__total' )
+ .text( fmt( total ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__localtotal' )
+ .text( mw.msg(
+ 'cx-stats-local-published',
+ fmt( langTotal ),
+ fmt( localLanguage )
+ )
+ )
);
$weeklyStats = $( 'div' )
.addClass( 'cx-stats-box' )
.append(
- $( 'div' ).addClass( 'cx-stats-box__title'
).text( mw.msg( 'cx-stats-weekly-published' ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__title' )
+ .text( mw.msg(
'cx-stats-weekly-published' ) ),
$( 'div' ).append(
- $( 'span' ).addClass(
'cx-stats-box__total' ).text( lastWeekTranslations ),
$( 'span' )
- .addClass( 'cx-stats-box__trend ' + (
weekTrend = 0 ? 'increase' : 'decrease' ) )
- .text( mw.msg( 'percent', weekTrend ) )
+ .addClass(
'cx-stats-box__total' )
+ .text( fmt(
lastWeekTranslations ) ),
+ $( 'span' )
+ .addClass( 'cx-stats-box__trend
' + ( weekTrend = 0 ? 'increase' : 'decrease' ) )
+ .text( mw.msg( 'percent', fmt(
weekTrend ) ) )
),
- $( 'div' ).addClass(
'cx-stats-box__localtotal' )
- .text( mw.msg( 'cx-stats-local-published',
- lastWeekLangTranslations + '(' +
mw.msg( 'percent', weekLangTrend ) + ')', localLanguage ) )
+ $( 'div' )
+ .addClass( 'cx-stats-box__localtotal' )
+ .text( mw.msg(
+ 'cx-stats-local-published',
+ fmt( lastWeekLangTranslations )
+ ' ('
+ + mw.msg( 'percent',
fmt( weekLangTrend ) ) + ')',
+ localLanguage
+ ) )
);
this.$highlights.append( $total, $weeklyStats );
};
@@ -219,7 +239,8 @@
[MediaWiki-commits] [Gerrit] Apply number formatting on new stats design - change (mediawiki...ContentTranslation)
Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216102
Change subject: Apply number formatting on new stats design
..
Apply number formatting on new stats design
Change-Id: I690d62b28338e6279b099db3f5295d82d7a5fdb7
---
M modules/stats/ext.cx.stats.js
1 file changed, 50 insertions(+), 19 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/02/216102/1
diff --git a/modules/stats/ext.cx.stats.js b/modules/stats/ext.cx.stats.js
index f150023..8fd00b7 100644
--- a/modules/stats/ext.cx.stats.js
+++ b/modules/stats/ext.cx.stats.js
@@ -69,7 +69,8 @@
lastWeekTotal, lastWeekLangTotal, weekTrend = 0,
weekLangTrend = 0,
lastWeekLangTranslations, prevWeekLangTotal,
lastWeekTranslations,
- prevWeekTotal, prevWeekTranslations,
prevWeekLangTranslations;
+ prevWeekTotal, prevWeekTranslations,
prevWeekLangTranslations,
+ fmt = mw.language.convertNumber;
if ( this.totalTranslationTrend.length 3 ) {
// Trend calculation works if we have enough data
@@ -104,25 +105,44 @@
$total = $( 'div' )
.addClass( 'cx-stats-box' )
.append(
- $( 'div' ).addClass( 'cx-stats-box__title'
).text( mw.msg( 'cx-stats-total-published' ) ),
- $( 'div' ).addClass( 'cx-stats-box__total'
).text( total ),
- $( 'div' ).addClass(
'cx-stats-box__localtotal' )
- .text( mw.msg( 'cx-stats-local-published',
langTotal, localLanguage ) )
+ $( 'div' )
+ .addClass( 'cx-stats-box__title' )
+ .text( mw.msg(
'cx-stats-total-published' ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__total' )
+ .text( fmt( total ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__localtotal' )
+ .text( mw.msg(
+ 'cx-stats-local-published',
+ fmt( langTotal ),
+ fmt( localLanguage )
+ )
+ )
);
$weeklyStats = $( 'div' )
.addClass( 'cx-stats-box' )
.append(
- $( 'div' ).addClass( 'cx-stats-box__title'
).text( mw.msg( 'cx-stats-weekly-published' ) ),
+ $( 'div' )
+ .addClass( 'cx-stats-box__title' )
+ .text( mw.msg(
'cx-stats-weekly-published' ) ),
$( 'div' ).append(
- $( 'span' ).addClass(
'cx-stats-box__total' ).text( lastWeekTranslations ),
$( 'span' )
- .addClass( 'cx-stats-box__trend ' + (
weekTrend = 0 ? 'increase' : 'decrease' ) )
- .text( mw.msg( 'percent', weekTrend ) )
+ .addClass(
'cx-stats-box__total' )
+ .text( fmt(
lastWeekTranslations ) ),
+ $( 'span' )
+ .addClass( 'cx-stats-box__trend
' + ( weekTrend = 0 ? 'increase' : 'decrease' ) )
+ .text( mw.msg( 'percent', fmt(
weekTrend ) ) )
),
- $( 'div' ).addClass(
'cx-stats-box__localtotal' )
- .text( mw.msg( 'cx-stats-local-published',
- lastWeekLangTranslations + '(' +
mw.msg( 'percent', weekLangTrend ) + ')', localLanguage ) )
+ $( 'div' )
+ .addClass( 'cx-stats-box__localtotal' )
+ .text( mw.msg(
+ 'cx-stats-local-published',
+ fmt( lastWeekLangTranslations )
+ '('
+ + mw.msg( 'percent',
fmt( weekLangTrend ) ) + ')',
+ localLanguage
+ ) )
);
