[MediaWiki-commits] [Gerrit] Avoid NPE when going from search to another page - change (apps...wikipedia)

2014-11-20 Thread Dbrant (Code Review) 
Dbrant has submitted this change and it was merged.

Change subject: Avoid NPE when going from search to another page
..


Avoid NPE when going from search to another page

java.lang.NullPointerException
at org.wikipedia.Utils.hideSoftKeyboard(Utils.java:171)
at 
org.wikipedia.search.SearchArticlesFragment.navigateToTitle(SearchArticlesFragment.java:481)
at 
org.wikipedia.search.SearchArticlesFragment.navigateToTitle(SearchArticlesFragment.java:476)

Change-Id: I763a4b1c2f4acbc257930eab97206843478f10e3
---
M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved



diff --git 
a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java 
b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
index f3b6644..d615a36 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
@@ -477,6 +477,9 @@
 }
 
 public void navigateToTitle(PageTitle title) {
+if (!isAdded()) {
+return;
+}
 HistoryEntry historyEntry = new HistoryEntry(title, 
HistoryEntry.SOURCE_SEARCH);
 Utils.hideSoftKeyboard(getActivity());
 closeSearch();

-- 
To view, visit https://gerrit.wikimedia.org/r/174636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I763a4b1c2f4acbc257930eab97206843478f10e3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Dbrant dbr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Avoid NPE when going from search to another page - change (apps...wikipedia)

2014-11-19 Thread BearND (Code Review) 
BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174636

Change subject: Avoid NPE when going from search to another page
..

Avoid NPE when going from search to another page

java.lang.NullPointerException
at org.wikipedia.Utils.hideSoftKeyboard(Utils.java:171)
at 
org.wikipedia.search.SearchArticlesFragment.navigateToTitle(SearchArticlesFragment.java:481)
at 
org.wikipedia.search.SearchArticlesFragment.navigateToTitle(SearchArticlesFragment.java:476)

Change-Id: I763a4b1c2f4acbc257930eab97206843478f10e3
---
M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/36/174636/1

diff --git 
a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java 
b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
index f3b6644..d615a36 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
@@ -477,6 +477,9 @@
 }
 
 public void navigateToTitle(PageTitle title) {
+if (!isAdded()) {
+return;
+}
 HistoryEntry historyEntry = new HistoryEntry(title, 
HistoryEntry.SOURCE_SEARCH);
 Utils.hideSoftKeyboard(getActivity());
 closeSearch();

-- 
To view, visit https://gerrit.wikimedia.org/r/174636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I763a4b1c2f4acbc257930eab97206843478f10e3
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits