[MediaWiki-commits] [Gerrit] Avoid that links break styles - change (mediawiki...MathSearch)

2014-10-12 Thread Physikerwelt (Code Review) 
Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/166359

Change subject: Avoid that links break styles
..

Avoid that links break styles

Wrapping the links to the FormulaInfo specialpage
avoids that the styles from the Math extension are broken.
The reason for that is that unclosed p-Tags prevent
cause invalid markup that is fixed badly by the browser.

Change-Id: If2bef6eb4af038174b8600515cfac1db9127830c
---
M MathSearch.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch 
refs/changes/59/166359/1

diff --git a/MathSearch.hooks.php b/MathSearch.hooks.php
index 202f079..cab93d8 100644
--- a/MathSearch.hooks.php
+++ b/MathSearch.hooks.php
@@ -179,7 +179,7 @@
static function addLinkToFormulaInfoPage( MathRenderer $Renderer, 
$Result = null, $pid = 0, $eid = 0 ) {
self::setMathId( $eid , $Renderer );
$url = SpecialPage::getTitleFor( 'FormulaInfo' )-getLocalUrl( 
array( 'pid' = $pid, 'eid' = $eid ) );
-   $Result = a href=\$url\ id=\$eid\ 
style=\color:inherit;\$Result/a;
+   $Result = diva href=\$url\ id=\$eid\ 
style=\color:inherit;\$Result/a/div;
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/166359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2bef6eb4af038174b8600515cfac1db9127830c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt w...@physikerwelt.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Avoid that links break styles - change (mediawiki...MathSearch)

2014-10-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Avoid that links break styles
..


Avoid that links break styles

Wrapping the links to the FormulaInfo specialpage
avoids that the styles from the Math extension are broken.
The reason for that is that unclosed p-Tags prevent
cause invalid markup that is fixed badly by the browser.

Change-Id: If2bef6eb4af038174b8600515cfac1db9127830c
---
M MathSearch.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Physikerwelt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MathSearch.hooks.php b/MathSearch.hooks.php
index 202f079..cab93d8 100644
--- a/MathSearch.hooks.php
+++ b/MathSearch.hooks.php
@@ -179,7 +179,7 @@
static function addLinkToFormulaInfoPage( MathRenderer $Renderer, 
$Result = null, $pid = 0, $eid = 0 ) {
self::setMathId( $eid , $Renderer );
$url = SpecialPage::getTitleFor( 'FormulaInfo' )-getLocalUrl( 
array( 'pid' = $pid, 'eid' = $eid ) );
-   $Result = a href=\$url\ id=\$eid\ 
style=\color:inherit;\$Result/a;
+   $Result = diva href=\$url\ id=\$eid\ 
style=\color:inherit;\$Result/a/div;
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/166359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2bef6eb4af038174b8600515cfac1db9127830c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt w...@physikerwelt.de
Gerrit-Reviewer: Physikerwelt w...@physikerwelt.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits