[MediaWiki-commits] [Gerrit] Bug 45622 - Allow invoking of SkinAfterBottomScripts - change (mediawiki...MobileFrontend)

2013-04-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Bug 45622 - Allow invoking of SkinAfterBottomScripts
..


Bug 45622 - Allow invoking of SkinAfterBottomScripts

This subtle change does exactly the same as before put also applies
the SkinAfterBottomScripts hook allowing extensions like Google Analytics
to be registered

Bug 45622

Change-Id: I29184aa66fa6ecb527aa384b670f193e54a63f81
---
M includes/skins/SkinMobile.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/skins/SkinMobile.php b/includes/skins/SkinMobile.php
index 9a0c6d1..22b84c3 100644
--- a/includes/skins/SkinMobile.php
+++ b/includes/skins/SkinMobile.php
@@ -269,7 +269,7 @@
$bottomScripts = '';
}
 
-   $bottomScripts .= $out-getBottomScripts();
+   $bottomScripts .= $this-bottomScripts();
} else {
$bottomScripts = '';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/57009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29184aa66fa6ecb527aa384b670f193e54a63f81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bug 45622 - Allow invoking of SkinAfterBottomScripts - change (mediawiki...MobileFrontend)

2013-04-01 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/57009


Change subject: Bug 45622 - Allow invoking of SkinAfterBottomScripts
..

Bug 45622 - Allow invoking of SkinAfterBottomScripts

This subtle change does exactly the same as before put also applies
the SkinAfterBottomScripts hook allowing extensions like Google Analytics
to be registered

Bug 45622

Change-Id: I29184aa66fa6ecb527aa384b670f193e54a63f81
---
M includes/skins/SkinMobile.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/09/57009/1

diff --git a/includes/skins/SkinMobile.php b/includes/skins/SkinMobile.php
index 9a0c6d1..22b84c3 100644
--- a/includes/skins/SkinMobile.php
+++ b/includes/skins/SkinMobile.php
@@ -269,7 +269,7 @@
$bottomScripts = '';
}
 
-   $bottomScripts .= $out-getBottomScripts();
+   $bottomScripts .= $this-bottomScripts();
} else {
$bottomScripts = '';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/57009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29184aa66fa6ecb527aa384b670f193e54a63f81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits