[MediaWiki-commits] [Gerrit] ButtonOptionWidget: Add the TabIndexedElement mixin - change (oojs/ui)

2015-01-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: ButtonOptionWidget: Add the TabIndexedElement mixin
..


ButtonOptionWidget: Add the TabIndexedElement mixin

This element should be keyboard navigable. It was before, probably got
lost in the TabIndexedElement rewrite.

Bug: T88085
Change-Id: Ic4d4f490661f32fbb731799bec836ff6870281cb
---
M src/widgets/ButtonOptionWidget.js
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/widgets/ButtonOptionWidget.js 
b/src/widgets/ButtonOptionWidget.js
index 207e044..d64639d 100644
--- a/src/widgets/ButtonOptionWidget.js
+++ b/src/widgets/ButtonOptionWidget.js
@@ -6,6 +6,7 @@
  * @class
  * @extends OO.ui.DecoratedOptionWidget
  * @mixins OO.ui.ButtonElement
+ * @mixins OO.ui.TabIndexedElement
  *
  * @constructor
  * @param {Object} [config] Configuration options
@@ -16,6 +17,7 @@
 
// Mixin constructors
OO.ui.ButtonElement.call( this, config );
+   OO.ui.TabIndexedElement.call( this, $.extend( {}, config, { 
$tabIndexed: this.$button } ) );
 
// Initialization
this.$element.addClass( 'oo-ui-buttonOptionWidget' );
@@ -27,6 +29,7 @@
 
 OO.inheritClass( OO.ui.ButtonOptionWidget, OO.ui.DecoratedOptionWidget );
 OO.mixinClass( OO.ui.ButtonOptionWidget, OO.ui.ButtonElement );
+OO.mixinClass( OO.ui.ButtonOptionWidget, OO.ui.TabIndexedElement );
 
 /* Static Properties */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/187652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4d4f490661f32fbb731799bec836ff6870281cb
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] ButtonOptionWidget: Add the TabIndexedElement mixin - change (oojs/ui)

2015-01-29 Thread TheDJ (Code Review) 
TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/187652

Change subject: ButtonOptionWidget: Add the TabIndexedElement mixin
..

ButtonOptionWidget: Add the TabIndexedElement mixin

This element should be keyboard navigable. It was before, probably got
lost in the TabIndexedElement rewrite.

Bug: T88085
Change-Id: Ic4d4f490661f32fbb731799bec836ff6870281cb
---
M src/widgets/ButtonOptionWidget.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/52/187652/1

diff --git a/src/widgets/ButtonOptionWidget.js 
b/src/widgets/ButtonOptionWidget.js
index 207e044..18b5b9f 100644
--- a/src/widgets/ButtonOptionWidget.js
+++ b/src/widgets/ButtonOptionWidget.js
@@ -16,6 +16,7 @@
 
// Mixin constructors
OO.ui.ButtonElement.call( this, config );
+   OO.ui.TabIndexedElement.call( this, $.extend( {}, config, { 
$tabIndexed: this.$button } ) );
 
// Initialization
this.$element.addClass( 'oo-ui-buttonOptionWidget' );
@@ -27,6 +28,7 @@
 
 OO.inheritClass( OO.ui.ButtonOptionWidget, OO.ui.DecoratedOptionWidget );
 OO.mixinClass( OO.ui.ButtonOptionWidget, OO.ui.ButtonElement );
+OO.mixinClass( OO.ui.ButtonOptionWidget, OO.ui.TabIndexedElement );
 
 /* Static Properties */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/187652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4d4f490661f32fbb731799bec836ff6870281cb
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: TheDJ 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits