[MediaWiki-commits] [Gerrit] CPB: Make LQT messages show up in CPB. - change (mediawiki...VectorBeta)

2014-06-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: CPB: Make LQT messages show up in CPB.
..


CPB: Make LQT messages show up in CPB.

I was missing these notification too often on mediawiki.org

Change-Id: I75d47503ca0ed3dfd68a66b60f0aaede0e96ebef
---
M resources/compactPersonalBar/compactPersonalBar.js
M resources/compactPersonalBar/compactPersonalBar.less
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/compactPersonalBar/compactPersonalBar.js 
b/resources/compactPersonalBar/compactPersonalBar.js
index b882f64..7c12398 100644
--- a/resources/compactPersonalBar/compactPersonalBar.js
+++ b/resources/compactPersonalBar/compactPersonalBar.js
@@ -121,6 +121,7 @@
count: $( '#pt-notifications' ).text(),
href: $( '#pt-notifications' ).find( 'a' 
).attr( 'href' )
} ) ).
+   addItem( 'interactions', 'newmessages', $( 
'#pt-newmessages' ).clone().attr( 'id', 'pt-newmessages-flyout' ) ).
addItem( 'interactions', 'talk', $( '#pt-mytalk' 
).clone().attr( 'id', 'pt-mytalk-flyout' ) ).
addItem( 'interactions', 'watchlist', $( 
'#pt-watchlist' ).clone().attr( 'id', 'pt-watchlist-flyout' ) ).
addItem( 'preferences', 'preferences', $( 
'#pt-preferences' ) ).
@@ -137,6 +138,7 @@
 
bar.
addItem( 'main', 'language', $( '#pt-uls' ) ).
+   addItem( 'main', 'newmessages', $( '#pt-newmessages' ) 
).
addItem( 'main', 'watchlist', $( '#pt-watchlist' ) ).
addItem( 'main', 'talk', $( '#pt-mytalk' ) ).
addItem( 'main', 'notifications', $( 
'#pt-notifications' ) ).
diff --git a/resources/compactPersonalBar/compactPersonalBar.less 
b/resources/compactPersonalBar/compactPersonalBar.less
index bb3bfda..1bab10f 100644
--- a/resources/compactPersonalBar/compactPersonalBar.less
+++ b/resources/compactPersonalBar/compactPersonalBar.less
@@ -158,6 +158,7 @@
.background-icon(notifications);
 }
 
+#pt-newmessages-flyout a,
 #pt-mytalk-flyout a {
.background-icon(talk);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/140248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75d47503ca0ed3dfd68a66b60f0aaede0e96ebef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: JGonera jgon...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Jorm bhar...@wikimedia.org
Gerrit-Reviewer: Yuvipanda yuvipa...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] CPB: Make LQT messages show up in CPB. - change (mediawiki...VectorBeta)

2014-06-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/140248

Change subject: CPB: Make LQT messages show up in CPB.
..

CPB: Make LQT messages show up in CPB.

I was missing these notification too often on mediawiki.org

Change-Id: I75d47503ca0ed3dfd68a66b60f0aaede0e96ebef
---
M resources/compactPersonalBar/compactPersonalBar.js
M resources/compactPersonalBar/compactPersonalBar.less
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VectorBeta 
refs/changes/48/140248/1

diff --git a/resources/compactPersonalBar/compactPersonalBar.js 
b/resources/compactPersonalBar/compactPersonalBar.js
index b882f64..7c12398 100644
--- a/resources/compactPersonalBar/compactPersonalBar.js
+++ b/resources/compactPersonalBar/compactPersonalBar.js
@@ -121,6 +121,7 @@
count: $( '#pt-notifications' ).text(),
href: $( '#pt-notifications' ).find( 'a' 
).attr( 'href' )
} ) ).
+   addItem( 'interactions', 'newmessages', $( 
'#pt-newmessages' ).clone().attr( 'id', 'pt-newmessages-flyout' ) ).
addItem( 'interactions', 'talk', $( '#pt-mytalk' 
).clone().attr( 'id', 'pt-mytalk-flyout' ) ).
addItem( 'interactions', 'watchlist', $( 
'#pt-watchlist' ).clone().attr( 'id', 'pt-watchlist-flyout' ) ).
addItem( 'preferences', 'preferences', $( 
'#pt-preferences' ) ).
@@ -137,6 +138,7 @@
 
bar.
addItem( 'main', 'language', $( '#pt-uls' ) ).
+   addItem( 'main', 'newmessages', $( '#pt-newmessages' ) 
).
addItem( 'main', 'watchlist', $( '#pt-watchlist' ) ).
addItem( 'main', 'talk', $( '#pt-mytalk' ) ).
addItem( 'main', 'notifications', $( 
'#pt-notifications' ) ).
diff --git a/resources/compactPersonalBar/compactPersonalBar.less 
b/resources/compactPersonalBar/compactPersonalBar.less
index bb3bfda..1bab10f 100644
--- a/resources/compactPersonalBar/compactPersonalBar.less
+++ b/resources/compactPersonalBar/compactPersonalBar.less
@@ -158,6 +158,7 @@
.background-icon(notifications);
 }
 
+#pt-newmessages-flyout a,
 #pt-mytalk-flyout a {
.background-icon(talk);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/140248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75d47503ca0ed3dfd68a66b60f0aaede0e96ebef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: TheDJ hartman.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits