[MediaWiki-commits] [Gerrit] Cached misses in getMulti should be omitted - change (mediawiki/core)
Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/134820
Change subject: Cached misses in getMulti should be omitted
..
Cached misses in getMulti should be omitted
SqlBagOStuff::getMulti currently returns an array with false values for missed
cache keys.
Default BagOStuff::getMulti (and other specific implementations like memcached),
however, just omit missed values.
e.g.:
$cache-getMulti( array( 'goodkey' 'badkey' ) );
should return
array( 'goodkey' = 'value' );
instead of
array( 'goodkey' = 'value', 'badkey' = false );
Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55
---
M includes/objectcache/SqlBagOStuff.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/134820/1
diff --git a/includes/objectcache/SqlBagOStuff.php
b/includes/objectcache/SqlBagOStuff.php
index bcd5942..483f8b9 100644
--- a/includes/objectcache/SqlBagOStuff.php
+++ b/includes/objectcache/SqlBagOStuff.php
@@ -270,7 +270,6 @@
array( 'keyname' =
$key, 'exptime' = $row-exptime ),
__METHOD__ );
$db-commit( __METHOD__,
'flush' );
- $values[$key] = false;
} else { // HIT
$values[$key] =
$this-unserialize( $db-decodeBlob( $row-value ) );
}
@@ -278,7 +277,6 @@
$this-handleWriteError( $e,
$row-serverIndex );
}
} else { // MISS
- $values[$key] = false;
$this-debug( 'get: no matching rows' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/134820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cached misses in getMulti should be omitted - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged.
Change subject: Cached misses in getMulti should be omitted
..
Cached misses in getMulti should be omitted
SqlBagOStuff::getMulti currently returns an array with false values for missed
cache keys.
Default BagOStuff::getMulti (and other specific implementations like memcached),
however, just omit missed values.
e.g.:
$cache-getMulti( array( 'goodkey' 'badkey' ) );
should return
array( 'goodkey' = 'value' );
instead of
array( 'goodkey' = 'value', 'badkey' = false );
Bug: 65637
Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55
---
M includes/objectcache/SqlBagOStuff.php
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/objectcache/SqlBagOStuff.php
b/includes/objectcache/SqlBagOStuff.php
index bcd5942..483f8b9 100644
--- a/includes/objectcache/SqlBagOStuff.php
+++ b/includes/objectcache/SqlBagOStuff.php
@@ -270,7 +270,6 @@
array( 'keyname' =
$key, 'exptime' = $row-exptime ),
__METHOD__ );
$db-commit( __METHOD__,
'flush' );
- $values[$key] = false;
} else { // HIT
$values[$key] =
$this-unserialize( $db-decodeBlob( $row-value ) );
}
@@ -278,7 +277,6 @@
$this-handleWriteError( $e,
$row-serverIndex );
}
} else { // MISS
- $values[$key] = false;
$this-debug( 'get: no matching rows' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/134820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2de06a0f76421094707f7ad4218346087f4dc55
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
