[MediaWiki-commits] [Gerrit] Change @throw to @throws - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172977

Change subject: Change @throw to @throws
..

Change @throw to @throws

Change-Id: I40067da35283f99ccf49f7fbc2cd76f9b62bc302
---
M lib/includes/store/CachingEntityRevisionLookup.php
M lib/includes/store/EntityLookup.php
M lib/includes/store/EntityRevisionLookup.php
M lib/includes/store/RedirectResolvingEntityLookup.php
M lib/includes/store/RevisionBasedEntityLookup.php
M lib/tests/phpunit/MockRepository.php
6 files changed, 11 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/77/172977/1

diff --git a/lib/includes/store/CachingEntityRevisionLookup.php 
b/lib/includes/store/CachingEntityRevisionLookup.php
index c6073cd..8db4bef 100644
--- a/lib/includes/store/CachingEntityRevisionLookup.php
+++ b/lib/includes/store/CachingEntityRevisionLookup.php
@@ -97,7 +97,7 @@
 * @param EntityId $entityId
 * @param int  $revisionId The desired revision id, 0 means 
current.
 *
-* @throw StorageException
+* @throws StorageException
 * @return EntityRevision|null
 */
public function getEntityRevision( EntityId $entityId, $revisionId = 0 
) {
@@ -136,8 +136,8 @@
 * @param EntityId $entityId
 * @param int $revisionId
 *
-* @throw StorageException
-* @return null|EntityRevision
+* @throws StorageException
+* @return EntityRevision|null
 */
private function fetchEntityRevision( EntityId $entityId, $revisionId = 
0 ) {
wfProfileIn( __METHOD__ );
diff --git a/lib/includes/store/EntityLookup.php 
b/lib/includes/store/EntityLookup.php
index 860f040..52e6a54 100644
--- a/lib/includes/store/EntityLookup.php
+++ b/lib/includes/store/EntityLookup.php
@@ -28,7 +28,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId );
@@ -46,7 +46,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId );
diff --git a/lib/includes/store/EntityRevisionLookup.php 
b/lib/includes/store/EntityRevisionLookup.php
index 60979fa..c028f4b 100644
--- a/lib/includes/store/EntityRevisionLookup.php
+++ b/lib/includes/store/EntityRevisionLookup.php
@@ -28,7 +28,7 @@
 * @param EntityId $entityId
 * @param int $revisionId The desired revision id, 0 means current.
 *
-* @throw StorageException
+* @throws StorageException
 * @return EntityRevision|null
 */
public function getEntityRevision( EntityId $entityId, $revisionId = 0 
);
diff --git a/lib/includes/store/RedirectResolvingEntityLookup.php 
b/lib/includes/store/RedirectResolvingEntityLookup.php
index 685caa6..9b33c3c 100644
--- a/lib/includes/store/RedirectResolvingEntityLookup.php
+++ b/lib/includes/store/RedirectResolvingEntityLookup.php
@@ -43,7 +43,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId ) {
@@ -58,7 +58,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId ) {
diff --git a/lib/includes/store/RevisionBasedEntityLookup.php 
b/lib/includes/store/RevisionBasedEntityLookup.php
index 32e41cd..ef455a3 100644
--- a/lib/includes/store/RevisionBasedEntityLookup.php
+++ b/lib/includes/store/RevisionBasedEntityLookup.php
@@ -34,7 +34,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId ) {
@@ -47,7 +47,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId ) {
diff --git a/lib/tests/phpunit/MockRepository.php 
b/lib/tests/phpunit/MockRepository.php
index f644b3c..a4b9ef9 100644
--- a/lib/tests/phpunit/MockRepository.php
+++ b/lib/tests/phpunit/MockRepository.php
@@ -95,7 +95,7 @@
 *
 * @return Entity|null
 *
-* @throw StorageException
+* @throws StorageException
 */
public function getEntity( EntityId $entityId ) {
$rev = $this-getEntityRevision( $entityId );

[MediaWiki-commits] [Gerrit] Change @throw to @throws - change (mediawiki...Wikibase)

2014-11-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Change @throw to @throws
..


Change @throw to @throws

Change-Id: I40067da35283f99ccf49f7fbc2cd76f9b62bc302
---
M lib/includes/store/CachingEntityRevisionLookup.php
M lib/includes/store/EntityLookup.php
M lib/includes/store/EntityRevisionLookup.php
M lib/includes/store/RedirectResolvingEntityLookup.php
M lib/includes/store/RevisionBasedEntityLookup.php
M lib/tests/phpunit/MockRepository.php
6 files changed, 11 insertions(+), 12 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/includes/store/CachingEntityRevisionLookup.php 
b/lib/includes/store/CachingEntityRevisionLookup.php
index c6073cd..8db4bef 100644
--- a/lib/includes/store/CachingEntityRevisionLookup.php
+++ b/lib/includes/store/CachingEntityRevisionLookup.php
@@ -97,7 +97,7 @@
 * @param EntityId $entityId
 * @param int  $revisionId The desired revision id, 0 means 
current.
 *
-* @throw StorageException
+* @throws StorageException
 * @return EntityRevision|null
 */
public function getEntityRevision( EntityId $entityId, $revisionId = 0 
) {
@@ -136,8 +136,8 @@
 * @param EntityId $entityId
 * @param int $revisionId
 *
-* @throw StorageException
-* @return null|EntityRevision
+* @throws StorageException
+* @return EntityRevision|null
 */
private function fetchEntityRevision( EntityId $entityId, $revisionId = 
0 ) {
wfProfileIn( __METHOD__ );
diff --git a/lib/includes/store/EntityLookup.php 
b/lib/includes/store/EntityLookup.php
index 860f040..52e6a54 100644
--- a/lib/includes/store/EntityLookup.php
+++ b/lib/includes/store/EntityLookup.php
@@ -28,7 +28,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId );
@@ -46,7 +46,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId );
diff --git a/lib/includes/store/EntityRevisionLookup.php 
b/lib/includes/store/EntityRevisionLookup.php
index 60979fa..c028f4b 100644
--- a/lib/includes/store/EntityRevisionLookup.php
+++ b/lib/includes/store/EntityRevisionLookup.php
@@ -28,7 +28,7 @@
 * @param EntityId $entityId
 * @param int $revisionId The desired revision id, 0 means current.
 *
-* @throw StorageException
+* @throws StorageException
 * @return EntityRevision|null
 */
public function getEntityRevision( EntityId $entityId, $revisionId = 0 
);
diff --git a/lib/includes/store/RedirectResolvingEntityLookup.php 
b/lib/includes/store/RedirectResolvingEntityLookup.php
index 685caa6..9b33c3c 100644
--- a/lib/includes/store/RedirectResolvingEntityLookup.php
+++ b/lib/includes/store/RedirectResolvingEntityLookup.php
@@ -43,7 +43,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId ) {
@@ -58,7 +58,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId ) {
diff --git a/lib/includes/store/RevisionBasedEntityLookup.php 
b/lib/includes/store/RevisionBasedEntityLookup.php
index 32e41cd..ef455a3 100644
--- a/lib/includes/store/RevisionBasedEntityLookup.php
+++ b/lib/includes/store/RevisionBasedEntityLookup.php
@@ -34,7 +34,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return Entity|null
 */
public function getEntity( EntityId $entityId ) {
@@ -47,7 +47,7 @@
 *
 * @param EntityId $entityId
 *
-* @throw StorageException
+* @throws StorageException
 * @return bool
 */
public function hasEntity( EntityId $entityId ) {
diff --git a/lib/tests/phpunit/MockRepository.php 
b/lib/tests/phpunit/MockRepository.php
index f644b3c..a4b9ef9 100644
--- a/lib/tests/phpunit/MockRepository.php
+++ b/lib/tests/phpunit/MockRepository.php
@@ -95,7 +95,7 @@
 *
 * @return Entity|null
 *
-* @throw StorageException
+* @throws StorageException
 */
public function getEntity( EntityId $entityId ) {
$rev = $this-getEntityRevision( $entityId );
@@ -112,7 +112,6 @@
 *
 * @throws StorageException