[MediaWiki-commits] [Gerrit] Changed table structure for Booleans - change (mediawiki...SemanticMediaWiki[storerewrite])

2012-07-05 Thread Nischayn22 (Code Review)
Nischayn22 has uploaded a new change for review.

Change subject: Changed table structure for Booleans
..

Changed table structure for Booleans

Using Boolean for PgSQL(not tested) and TINYINT(1) for MySQL
Note: Using BIT for MySQL has some issues so we prefer using TINYINT(1)
  since both take up equal space

Change-Id: Ie794c4c601308ee2e93299f8cdafbac00734f4ba
---
M includes/storage/SMW_DIHandler_Bool.php
M includes/storage/SMW_SQLStore2_SetupHandlers.php
2 files changed, 15 insertions(+), 13 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/04/14304/1
--
To view, visit https://gerrit.wikimedia.org/r/14304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie794c4c601308ee2e93299f8cdafbac00734f4ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: storerewrite
Gerrit-Owner: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Changed table structure for Booleans - change (mediawiki...SemanticMediaWiki[storerewrite])

2012-07-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Changed table structure for Booleans
..


Changed table structure for Booleans

Using Boolean for PgSQL(not tested) and TINYINT(1) for MySQL
Note: Using BIT for MySQL has some issues so we prefer using TINYINT(1)
  since both take up equal space
Patchset2: Refactoring

Change-Id: Ie794c4c601308ee2e93299f8cdafbac00734f4ba
---
M includes/storage/SMW_DIHandler_Bool.php
M includes/storage/SMW_SQLStore2_SetupHandlers.php
2 files changed, 22 insertions(+), 27 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie794c4c601308ee2e93299f8cdafbac00734f4ba
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: storerewrite
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits