[MediaWiki-commits] [Gerrit] Cleanup dialog properties - change (mediawiki...VisualEditor)
Trevor Parscal has uploaded a new change for review. https://gerrit.wikimedia.org/r/116010 Change subject: Cleanup dialog properties .. Cleanup dialog properties No need to re-initialize properties set in parent class. Change-Id: Ib98d9636ef169f58b4044d09972063bd5f19b3af --- M modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/10/116010/1 diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js index 75629b1..067d21f 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js @@ -18,11 +18,6 @@ ve.ui.MWAdvancedTransclusionDialog = function VeUiMWAdvancedTransclusionDialog( windowSet, config ) { // Parent constructor ve.ui.MWTransclusionDialog.call( this, windowSet, config ); - - // Properties - this.node = null; - this.transclusion = null; - this.loaded = false; }; /* Inheritance */ diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js index b39ae6f..45c6656 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js @@ -18,11 +18,6 @@ ve.ui.MWTemplateDialog = function VeUiMWTemplateDialog( windowSet, config ) { // Parent constructor ve.ui.MWTransclusionDialog.call( this, windowSet, config ); - - // Properties - this.node = null; - this.transclusion = null; - this.loaded = false; }; /* Inheritance */ -- To view, visit https://gerrit.wikimedia.org/r/116010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib98d9636ef169f58b4044d09972063bd5f19b3af Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup dialog properties - change (mediawiki...VisualEditor)
jenkins-bot has submitted this change and it was merged. Change subject: Cleanup dialog properties .. Cleanup dialog properties No need to re-initialize properties set in parent class. Change-Id: Ib98d9636ef169f58b4044d09972063bd5f19b3af --- M modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js index 71c64dd..4460284 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js @@ -18,11 +18,6 @@ ve.ui.MWAdvancedTransclusionDialog = function VeUiMWAdvancedTransclusionDialog( windowSet, config ) { // Parent constructor ve.ui.MWTransclusionDialog.call( this, windowSet, config ); - - // Properties - this.node = null; - this.transclusion = null; - this.loaded = false; }; /* Inheritance */ diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js index cda4a72..204812b 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js @@ -18,11 +18,6 @@ ve.ui.MWTemplateDialog = function VeUiMWTemplateDialog( windowSet, config ) { // Parent constructor ve.ui.MWTransclusionDialog.call( this, windowSet, config ); - - // Properties - this.node = null; - this.transclusion = null; - this.loaded = false; }; /* Inheritance */ -- To view, visit https://gerrit.wikimedia.org/r/116010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib98d9636ef169f58b4044d09972063bd5f19b3af Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal Gerrit-Reviewer: Catrope Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits