[MediaWiki-commits] [Gerrit] Cleanup page class names and comments - change (mediawiki...VisualEditor)

2014-02-27 Thread Trevor Parscal (Code Review) 
Trevor Parscal has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116009

Change subject: Cleanup page class names and comments
..

Cleanup page class names and comments

Change-Id: I739b5d9b295d09b86104133a8f4eb30070d664f2
---
M modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
3 files changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/09/116009/1

diff --git a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
index af4fb31..d5d8595 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWParameterPage = function VeUiMWParameter( parameter, name, config ) {
+ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config 
) {
var paramName = parameter.getName();
 
// Parent constructor
@@ -47,7 +47,6 @@
} )
.connect( this, { 'click': 'onRemoveButtonClick' } );
 
-   // TODO: Use spec.required
// TODO: Use spec.deprecation
// TODO: Use spec.type
 
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
index a54dbeb..8b7d5c2 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholder( 
placeholder, name, config ) {
+ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholderPage( 
placeholder, name, config ) {
// Parent constructor
OO.ui.PageLayout.call( this, name, config );
 
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
index 1c697b7..dce6262 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWTransclusionContentPage = function VeUiMWTransclusionContent( content, 
name, config ) {
+ve.ui.MWTransclusionContentPage = function VeUiMWTransclusionContentPage( 
content, name, config ) {
// Parent constructor
OO.ui.PageLayout.call( this, name, config );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I739b5d9b295d09b86104133a8f4eb30070d664f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Cleanup page class names and comments - change (mediawiki...VisualEditor)

2014-02-28 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Cleanup page class names and comments
..


Cleanup page class names and comments

Change-Id: I739b5d9b295d09b86104133a8f4eb30070d664f2
---
M modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
M modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
3 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
index 65218e5..c638257 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWParameterPage = function VeUiMWParameter( parameter, name, config ) {
+ve.ui.MWParameterPage = function VeUiMWParameterPage( parameter, name, config 
) {
var paramName = parameter.getName();
 
// Parent constructor
@@ -48,7 +48,6 @@
} )
.connect( this, { 'click': 'onRemoveButtonClick' } );
 
-   // TODO: Use spec.required
// TODO: Use spec.deprecation
// TODO: Use spec.type
 
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
index a54dbeb..8b7d5c2 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTemplatePlaceholderPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholder( 
placeholder, name, config ) {
+ve.ui.MWTemplatePlaceholderPage = function VeUiMWTemplatePlaceholderPage( 
placeholder, name, config ) {
// Parent constructor
OO.ui.PageLayout.call( this, name, config );
 
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
index 1c697b7..dce6262 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWTransclusionContentPage.js
@@ -16,7 +16,7 @@
  * @param {string} name Unique symbolic name of page
  * @param {Object} [config] Configuration options
  */
-ve.ui.MWTransclusionContentPage = function VeUiMWTransclusionContent( content, 
name, config ) {
+ve.ui.MWTransclusionContentPage = function VeUiMWTransclusionContentPage( 
content, name, config ) {
// Parent constructor
OO.ui.PageLayout.call( this, name, config );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I739b5d9b295d09b86104133a8f4eb30070d664f2
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits