[MediaWiki-commits] [Gerrit] Close nav menu as soon as Random is tapped. - change (apps...wikipedia)
jenkins-bot has submitted this change and it was merged. Change subject: Close nav menu as soon as Random is tapped. .. Close nav menu as soon as Random is tapped. Bug: T135448 Change-Id: Ic5467be50abd4fc38957c0a2dc38463127fade10 --- M app/src/main/java/org/wikipedia/page/NavDrawerHelper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Niedzielski: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java b/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java index 776334a..f47f88f 100644 --- a/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java +++ b/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java @@ -104,6 +104,7 @@ break; case R.id.nav_item_random: activity.getRandomHandler().doVisitRandomArticle(); +activity.closeNavDrawer(); funnel.logRandom(); break; case R.id.nav_item_donate: -- To view, visit https://gerrit.wikimedia.org/r/290950 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5467be50abd4fc38957c0a2dc38463127fade10 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: DbrantGerrit-Reviewer: BearND Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Mholloway Gerrit-Reviewer: Niedzielski Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Close nav menu as soon as Random is tapped. - change (apps...wikipedia)
Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/290950 Change subject: Close nav menu as soon as Random is tapped. .. Close nav menu as soon as Random is tapped. Bug: T135448 Change-Id: Ic5467be50abd4fc38957c0a2dc38463127fade10 --- M app/src/main/java/org/wikipedia/page/NavDrawerHelper.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/50/290950/1 diff --git a/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java b/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java index 776334a..f47f88f 100644 --- a/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java +++ b/app/src/main/java/org/wikipedia/page/NavDrawerHelper.java @@ -104,6 +104,7 @@ break; case R.id.nav_item_random: activity.getRandomHandler().doVisitRandomArticle(); +activity.closeNavDrawer(); funnel.logRandom(); break; case R.id.nav_item_donate: -- To view, visit https://gerrit.wikimedia.org/r/290950 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5467be50abd4fc38957c0a2dc38463127fade10 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits