[MediaWiki-commits] [Gerrit] Convert log.Timer and log.Stats to use context logger - change (mediawiki...scap)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Convert log.Timer and log.Stats to use context logger
..


Convert log.Timer and log.Stats to use context logger

Change-Id: Ibd72c991040eb07810dd4f3c435c475743df7d4c
---
M scap/log.py
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scap/log.py b/scap/log.py
index 00f8504..caa4bb7 100644
--- a/scap/log.py
+++ b/scap/log.py
@@ -258,8 +258,9 @@
 See  for details.
 """
 
-def __init__(self, host, port):
-self.logger = logging.getLogger('stats')
+@utils.log_context('stats')
+def __init__(self, host, port, logger=None):
+self.logger = logger
 self.socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
 self.address = (host, port)
 
@@ -301,7 +302,8 @@
 ... t.mark('copy phase 2')
 """
 
-def __init__(self, label, stats=None):
+@utils.log_context('timer')
+def __init__(self, label, stats=None, logger=None):
 """
 :param label: Label for block (e.g. 'scap' or 'rsync')
 :type label: str
@@ -310,7 +312,7 @@
 """
 self.label = label
 self.stats = stats
-self.logger = logging.getLogger('timer')
+self.logger = logger
 
 def mark(self, label):
 """

-- 
To view, visit https://gerrit.wikimedia.org/r/241067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd72c991040eb07810dd4f3c435c475743df7d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/scap
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Convert log.Timer and log.Stats to use context logger - change (mediawiki...scap)

[Chad (Code Review)]

Chad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/241067

Change subject: Convert log.Timer and log.Stats to use context logger
..

Convert log.Timer and log.Stats to use context logger

Change-Id: Ibd72c991040eb07810dd4f3c435c475743df7d4c
---
M scap/log.py
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/scap 
refs/changes/67/241067/1

diff --git a/scap/log.py b/scap/log.py
index 00f8504..caa4bb7 100644
--- a/scap/log.py
+++ b/scap/log.py
@@ -258,8 +258,9 @@
 See  for details.
 """
 
-def __init__(self, host, port):
-self.logger = logging.getLogger('stats')
+@utils.log_context('stats')
+def __init__(self, host, port, logger=None):
+self.logger = logger
 self.socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
 self.address = (host, port)
 
@@ -301,7 +302,8 @@
 ... t.mark('copy phase 2')
 """
 
-def __init__(self, label, stats=None):
+@utils.log_context('timer')
+def __init__(self, label, stats=None, logger=None):
 """
 :param label: Label for block (e.g. 'scap' or 'rsync')
 :type label: str
@@ -310,7 +312,7 @@
 """
 self.label = label
 self.stats = stats
-self.logger = logging.getLogger('timer')
+self.logger = logger
 
 def mark(self, label):
 """

-- 
To view, visit https://gerrit.wikimedia.org/r/241067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd72c991040eb07810dd4f3c435c475743df7d4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/scap
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits