[MediaWiki-commits] [Gerrit] Convert string to integer in puppet.cron.er - change (operations/puppet)

2013-11-22 Thread Akosiaris (Code Review) 
Akosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96998


Change subject: Convert string to integer in puppet.cron.er
..

Convert string to integer in puppet.cron.er

5acd376976946b89894ff28a2eb7c716bffad5ed inserted a bug where
puppet.cron.erb would not compiled correctly due to doing arithmetic
with strings. Converting them to integers first to solve the issue

Change-Id: If75e8265d74bcc30fe42951a8dd5d10b2aaa5684
---
M modules/base/templates/puppet.cron.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/96998/1

diff --git a/modules/base/templates/puppet.cron.erb 
b/modules/base/templates/puppet.cron.erb
index a568f55..d54c903 100644
--- a/modules/base/templates/puppet.cron.erb
+++ b/modules/base/templates/puppet.cron.erb
@@ -3,8 +3,8 @@
 #  as template('base/puppet.cron.erb')
 ##
 %-
-interval = scope.lookupvar('base::puppet::interval')
-crontime = scope.lookupvar('base::puppet::crontime')
+interval = scope.lookupvar('base::puppet::interval').to_i
+crontime = scope.lookupvar('base::puppet::crontime').to_i
 numtimes = 60 / interval
 tmp = Array.new(numtimes) { |t| t = t * interval + crontime }
 tmp = tmp.map { |x| if x  60 then x  else x - 60 end }

-- 
To view, visit https://gerrit.wikimedia.org/r/96998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If75e8265d74bcc30fe42951a8dd5d10b2aaa5684
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Akosiaris akosia...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Convert string to integer in puppet.cron.er - change (operations/puppet)

2013-11-22 Thread Akosiaris (Code Review) 
Akosiaris has submitted this change and it was merged.

Change subject: Convert string to integer in puppet.cron.er
..


Convert string to integer in puppet.cron.er

5acd376976946b89894ff28a2eb7c716bffad5ed inserted a bug where
puppet.cron.erb would not compiled correctly due to doing arithmetic
with strings. Converting them to integers first to solve the issue

Change-Id: If75e8265d74bcc30fe42951a8dd5d10b2aaa5684
---
M modules/base/templates/puppet.cron.erb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Akosiaris: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/base/templates/puppet.cron.erb 
b/modules/base/templates/puppet.cron.erb
index a568f55..d54c903 100644
--- a/modules/base/templates/puppet.cron.erb
+++ b/modules/base/templates/puppet.cron.erb
@@ -3,8 +3,8 @@
 #  as template('base/puppet.cron.erb')
 ##
 %-
-interval = scope.lookupvar('base::puppet::interval')
-crontime = scope.lookupvar('base::puppet::crontime')
+interval = scope.lookupvar('base::puppet::interval').to_i
+crontime = scope.lookupvar('base::puppet::crontime').to_i
 numtimes = 60 / interval
 tmp = Array.new(numtimes) { |t| t = t * interval + crontime }
 tmp = tmp.map { |x| if x  60 then x  else x - 60 end }

-- 
To view, visit https://gerrit.wikimedia.org/r/96998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If75e8265d74bcc30fe42951a8dd5d10b2aaa5684
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Akosiaris akosia...@wikimedia.org
Gerrit-Reviewer: Akosiaris akosia...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits