[MediaWiki-commits] [Gerrit] Convert wikimedia_sites to use requests - change (pywikibot/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Convert wikimedia_sites to use requests
..


Convert wikimedia_sites to use requests

Bug: T130524
Change-Id: I2a076683a7de84b3b3ad05947ba02383fc1b6d8c
---
M scripts/maintenance/wikimedia_sites.py
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Mpaa: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/maintenance/wikimedia_sites.py 
b/scripts/maintenance/wikimedia_sites.py
index 3c56c28..b0d235d 100755
--- a/scripts/maintenance/wikimedia_sites.py
+++ b/scripts/maintenance/wikimedia_sites.py
@@ -14,18 +14,14 @@
 
 import codecs
 import re
-import sys
+
+import requests
 
 from xml.etree import cElementTree
 
 import pywikibot
 
 from pywikibot.family import Family
-
-if sys.version_info[0] > 2:
-from urllib.request import urlopen
-else:
-from urllib import urlopen
 
 URL = 'https://wikistats.wmflabs.org/api.php?action=dump=%s=xml'
 
@@ -52,7 +48,7 @@
 original = Family.load(family).languages_by_size
 obsolete = Family.load(family).obsolete
 
-feed = urlopen(URL % familiesDict[family])
+feed = requests.get(URL % familiesDict[family])
 tree = cElementTree.parse(feed)
 
 new = []

-- 
To view, visit https://gerrit.wikimedia.org/r/300747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a076683a7de84b3b3ad05947ba02383fc1b6d8c
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: MtDu 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: Mpaa 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Convert wikimedia_sites to use requests - change (pywikibot/core)

[MtDu (Code Review)]

MtDu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/300747

Change subject: Convert wikimedia_sites to use requests
..

Convert wikimedia_sites to use requests

Bug: T130524
Change-Id: I2a076683a7de84b3b3ad05947ba02383fc1b6d8c
---
M scripts/maintenance/wikimedia_sites.py
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/47/300747/1

diff --git a/scripts/maintenance/wikimedia_sites.py 
b/scripts/maintenance/wikimedia_sites.py
index 3c56c28..a3d4a2d 100755
--- a/scripts/maintenance/wikimedia_sites.py
+++ b/scripts/maintenance/wikimedia_sites.py
@@ -14,6 +14,7 @@
 
 import codecs
 import re
+import requests
 import sys
 
 from xml.etree import cElementTree
@@ -21,11 +22,6 @@
 import pywikibot
 
 from pywikibot.family import Family
-
-if sys.version_info[0] > 2:
-from urllib.request import urlopen
-else:
-from urllib import urlopen
 
 URL = 'https://wikistats.wmflabs.org/api.php?action=dump=%s=xml'
 
@@ -52,7 +48,7 @@
 original = Family.load(family).languages_by_size
 obsolete = Family.load(family).obsolete
 
-feed = urlopen(URL % familiesDict[family])
+feed = requests.get(URL % familiesDict[family])
 tree = cElementTree.parse(feed)
 
 new = []

-- 
To view, visit https://gerrit.wikimedia.org/r/300747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a076683a7de84b3b3ad05947ba02383fc1b6d8c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: MtDu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits