[MediaWiki-commits] [Gerrit] Coverage now ignore phpunit ignores - change (integration/jenkins-job-builder-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/116093 Change subject: Coverage now ignore phpunit ignores .. Coverage now ignore phpunit ignores phpunit segfault (bug 43972) which in turns prevents the Jenkins Clover PHP Plugin from generating the coverage report. Workaround is to ignore errors using shell trick '|| :'. The Jenkins feature request to have coverage report to always run is: https://issues.jenkins-ci.org/browse/JENKINS-21046 Bug: 43972 Change-Id: I39ec04275b9695ddd2890425b6a50458382e80df --- M mediawiki.yaml 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config refs/changes/93/116093/1 diff --git a/mediawiki.yaml b/mediawiki.yaml index aec28f5..757f366 100644 --- a/mediawiki.yaml +++ b/mediawiki.yaml @@ -252,7 +252,12 @@ --with-phpunitdir /srv/deployment/integration/phpunit/vendor/phpunit/phpunit \ --exclude-group Dump,Broken,ParserFuzz,Stub \ --coverage-clover log/clover.xml \ ---coverage-html /srv/org/wikimedia/integration/cover/mediawiki-core/master/php +--coverage-html /srv/org/wikimedia/integration/cover/mediawiki-core/master/php \ +|| : +# PHP segfault (bug 43972) so ignore any error with '|| :' or the +# Jenkins plugin will never generate the coverage report for us +# https://issues.jenkins-ci.org/browse/JENKINS-21046 + echo Code coverage report is available at: echo https://integration.wikimedia.org/cover/mediawiki-core/master/php; publishers: -- To view, visit https://gerrit.wikimedia.org/r/116093 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39ec04275b9695ddd2890425b6a50458382e80df Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Coverage now ignore phpunit ignores - change (integration/jenkins-job-builder-config)
jenkins-bot has submitted this change and it was merged. Change subject: Coverage now ignore phpunit ignores .. Coverage now ignore phpunit ignores phpunit segfault (bug 43972) which in turns prevents the Jenkins Clover PHP Plugin from generating the coverage report. Workaround is to ignore errors using shell trick '|| :'. The Jenkins feature request to have coverage report to always run is: https://issues.jenkins-ci.org/browse/JENKINS-21046 Bug: 43972 Change-Id: I39ec04275b9695ddd2890425b6a50458382e80df --- M mediawiki.yaml 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/mediawiki.yaml b/mediawiki.yaml index aec28f5..757f366 100644 --- a/mediawiki.yaml +++ b/mediawiki.yaml @@ -252,7 +252,12 @@ --with-phpunitdir /srv/deployment/integration/phpunit/vendor/phpunit/phpunit \ --exclude-group Dump,Broken,ParserFuzz,Stub \ --coverage-clover log/clover.xml \ ---coverage-html /srv/org/wikimedia/integration/cover/mediawiki-core/master/php +--coverage-html /srv/org/wikimedia/integration/cover/mediawiki-core/master/php \ +|| : +# PHP segfault (bug 43972) so ignore any error with '|| :' or the +# Jenkins plugin will never generate the coverage report for us +# https://issues.jenkins-ci.org/browse/JENKINS-21046 + echo Code coverage report is available at: echo https://integration.wikimedia.org/cover/mediawiki-core/master/php; publishers: -- To view, visit https://gerrit.wikimedia.org/r/116093 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39ec04275b9695ddd2890425b6a50458382e80df Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits