[MediaWiki-commits] [Gerrit] CreateClass cannot save and returns Bad title when there is ... - change (mediawiki...SemanticForms)

2016-06-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: CreateClass cannot save and returns Bad title when there is a 
non-ASCII character in the special page name
..


CreateClass cannot save and returns Bad title when there is a non-ASCII 
character in the special page name

Bug: T137664
Change-Id: I59aa07d024227bb93b170784f04dc03f07b9621a
---
M includes/SF_Utils.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SF_Utils.php b/includes/SF_Utils.php
index ddea022..8a215f0 100644
--- a/includes/SF_Utils.php
+++ b/includes/SF_Utils.php
@@ -24,7 +24,7 @@
 * some reason, doesn't include the namespace
 */
public static function titleURLString( $title ) {
-   $namespace = wfUrlencode( $title->getNsText() );
+   $namespace = $title->getNsText();
if ( $namespace !== '' ) {
$namespace .= ':';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/293968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59aa07d024227bb93b170784f04dc03f07b9621a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: Seb35 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] CreateClass cannot save and returns Bad title when there is ... - change (mediawiki...SemanticForms)

2016-06-12 Thread Seb35 (Code Review) 
Seb35 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293968

Change subject: CreateClass cannot save and returns Bad title when there is a 
non-ASCII character in the special page name
..

CreateClass cannot save and returns Bad title when there is a non-ASCII 
character in the special page name

Bug: T137664
Change-Id: I59aa07d024227bb93b170784f04dc03f07b9621a
---
M includes/SF_Utils.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/68/293968/1

diff --git a/includes/SF_Utils.php b/includes/SF_Utils.php
index ddea022..8a215f0 100644
--- a/includes/SF_Utils.php
+++ b/includes/SF_Utils.php
@@ -24,7 +24,7 @@
 * some reason, doesn't include the namespace
 */
public static function titleURLString( $title ) {
-   $namespace = wfUrlencode( $title->getNsText() );
+   $namespace = $title->getNsText();
if ( $namespace !== '' ) {
$namespace .= ':';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/293968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59aa07d024227bb93b170784f04dc03f07b9621a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits