[MediaWiki-commits] [Gerrit] Cursor fix after link insertion - change (mediawiki...VisualEditor)

2013-08-29 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81872


Change subject: Cursor fix after link insertion
..

Cursor fix after link insertion

When a link was inserted, the cursor position was backwards (at the beginning
of the word rather than its end) - this commit fixes that problem.
Also, thanks for the help Ed!

Bug:53560
Change-Id: I04fe1ca4c9126898e7bf85cdf519794d66b4f38b
---
M modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/72/81872/1

diff --git a/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js 
b/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
index 1afb2b9..3d2de42 100644
--- a/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
+++ b/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
@@ -166,7 +166,7 @@
// Apply new annotation
fragment.annotateContent( 'set', annotation );
}
-   if ( action === 'back' ) {
+   if ( action === 'back' || insert ) {
// Restore selection to what it was before we expanded it
selection = this.previousSelection;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/81872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04fe1ca4c9126898e7bf85cdf519794d66b4f38b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Cursor fix after link insertion - change (mediawiki...VisualEditor)

2013-08-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Cursor fix after link insertion
..


Cursor fix after link insertion

When a link was inserted, the cursor position was backwards (at the
beginning of the word rather than its end) - this commit fixes that
problem.

Also, thanks for the help Ed!

Bug: 53560
Change-Id: I04fe1ca4c9126898e7bf85cdf519794d66b4f38b
---
M modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js 
b/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
index 1afb2b9..3d2de42 100644
--- a/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
+++ b/modules/ve/ui/inspectors/ve.ui.AnnotationInspector.js
@@ -166,7 +166,7 @@
// Apply new annotation
fragment.annotateContent( 'set', annotation );
}
-   if ( action === 'back' ) {
+   if ( action === 'back' || insert ) {
// Restore selection to what it was before we expanded it
selection = this.previousSelection;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/81872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04fe1ca4c9126898e7bf85cdf519794d66b4f38b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: Esanders esand...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits