[MediaWiki-commits] [Gerrit] Define $errstr - change (operations/software)

2014-03-31 Thread Springle (Code Review) 
Springle has submitted this change and it was merged.

Change subject: Define $errstr
..


Define $errstr

Change-Id: I79671f257dbdcccb5f3b1f66b5c9612ed431
---
M dbtree/index.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Springle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/dbtree/index.php b/dbtree/index.php
index 2f8c1d0..03e039c 100644
--- a/dbtree/index.php
+++ b/dbtree/index.php
@@ -26,6 +26,8 @@
$xml = simplexml_load_file('ganglia.xml');
return;
}
+
+   $errst = '';
$sock = fsockopen(ganglia.wikimedia.org, 8653, $errno, $errst, 30);
if (!$sock) {
echo Failed reading from ganglia: $errno - $errstrbr /\n;

-- 
To view, visit https://gerrit.wikimedia.org/r/118949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79671f257dbdcccb5f3b1f66b5c9612ed431
Gerrit-PatchSet: 3
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Springle sprin...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Define $errstr - change (operations/software)

2014-03-15 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/118949

Change subject: Define $errstr
..

Define $errstr

Change-Id: I79671f257dbdcccb5f3b1f66b5c9612ed431
---
M dbtree/index.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software 
refs/changes/49/118949/1

diff --git a/dbtree/index.php b/dbtree/index.php
index e97ed27..f446703 100644
--- a/dbtree/index.php
+++ b/dbtree/index.php
@@ -25,6 +25,7 @@
$buf = '';
//$xml = simplexml_load_file(ganglia.xml);
//return;
+   $errst = '';
$sock = fsockopen(ganglia.wikimedia.org, 8653, $errno, $errst, 30);
if (!$sock) {
echo Failed reading from ganglia: $errno - $errstrbr /\n;

-- 
To view, visit https://gerrit.wikimedia.org/r/118949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79671f257dbdcccb5f3b1f66b5c9612ed431
Gerrit-PatchSet: 1
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits