[MediaWiki-commits] [Gerrit] Display allowed skins if and only if the current skin is not... - change (mediawiki...BetaFeatures)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Display allowed skins if and only if the current skin is not 
allowed
..


Display allowed skins if and only if the current skin is not allowed

Bug: 70814
Change-Id: Ie138794df73e3a546759a87a420858c2c14ea874
---
M includes/HTMLFeatureField.php
M resources/betafeatures.less
2 files changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/HTMLFeatureField.php b/includes/HTMLFeatureField.php
index c570977..3116e0f 100644
--- a/includes/HTMLFeatureField.php
+++ b/includes/HTMLFeatureField.php
@@ -181,7 +181,7 @@
$html .= Html::closeElement( 'li' );
}
 
-   if ( isset( 
$this-mParams['requirements']['skin-not-supported'] ) ) {
+   if ( isset( 
$this-mParams['requirements']['skin-not-supported'] )  
$this-mParams['requirements']['skin-not-supported'] === true ) {
$html .= Html::openElement(
'li',
array( 'class' = 
'mw-ui-feature-requirements-skins' )
diff --git a/resources/betafeatures.less b/resources/betafeatures.less
index e9cdb0c..3229180 100644
--- a/resources/betafeatures.less
+++ b/resources/betafeatures.less
@@ -144,7 +144,3 @@
 .mw-ui-feature-requirements-list .mw-ui-feature-requirements-browser {
display: none;
 }
-
-.mw-ui-feature-requirements-list .mw-ui-feature-requirements-skins {
-   display: none;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/161629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie138794df73e3a546759a87a420858c2c14ea874
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Seb35 seb35wikipe...@gmail.com
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Display allowed skins if and only if the current skin is not... - change (mediawiki...BetaFeatures)

[Seb35 (Code Review)]

Seb35 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/161629

Change subject: Display allowed skins if and only if the current skin is not 
allowed
..

Display allowed skins if and only if the current skin is not allowed

Bug: 70814
Change-Id: Ie138794df73e3a546759a87a420858c2c14ea874
---
M includes/HTMLFeatureField.php
M resources/betafeatures.less
2 files changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures 
refs/changes/29/161629/1

diff --git a/includes/HTMLFeatureField.php b/includes/HTMLFeatureField.php
index c570977..3116e0f 100644
--- a/includes/HTMLFeatureField.php
+++ b/includes/HTMLFeatureField.php
@@ -181,7 +181,7 @@
$html .= Html::closeElement( 'li' );
}
 
-   if ( isset( 
$this-mParams['requirements']['skin-not-supported'] ) ) {
+   if ( isset( 
$this-mParams['requirements']['skin-not-supported'] )  
$this-mParams['requirements']['skin-not-supported'] === true ) {
$html .= Html::openElement(
'li',
array( 'class' = 
'mw-ui-feature-requirements-skins' )
diff --git a/resources/betafeatures.less b/resources/betafeatures.less
index e9cdb0c..3229180 100644
--- a/resources/betafeatures.less
+++ b/resources/betafeatures.less
@@ -144,7 +144,3 @@
 .mw-ui-feature-requirements-list .mw-ui-feature-requirements-browser {
display: none;
 }
-
-.mw-ui-feature-requirements-list .mw-ui-feature-requirements-skins {
-   display: none;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/161629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie138794df73e3a546759a87a420858c2c14ea874
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Seb35 seb35wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits