Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/298010
Change subject: Distinguish ArticlePlaceholder\SearchHookHandlerTest::insertPage() from MediaWikiTestCase::insertPage() ...................................................................... Distinguish ArticlePlaceholder\SearchHookHandlerTest::insertPage() from MediaWikiTestCase::insertPage() Both has different meanings and functionting, so the ArtickePlaceholder one shouldn't override the parent one. Change-Id: I28ef0f12cb534e3584018e2df36b2330319ff364 --- M tests/phpunit/includes/SearchHookHandlerTest.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder refs/changes/10/298010/1 diff --git a/tests/phpunit/includes/SearchHookHandlerTest.php b/tests/phpunit/includes/SearchHookHandlerTest.php index 171c695..232d1a3 100644 --- a/tests/phpunit/includes/SearchHookHandlerTest.php +++ b/tests/phpunit/includes/SearchHookHandlerTest.php @@ -154,10 +154,10 @@ ] ] ); - $this->insertPage( $db, $pageId, $entityIdSer, $itemNamespace ); + $this->insertPageToDb( $db, $pageId, $entityIdSer, $itemNamespace ); } - protected function insertPage( DatabaseBase $db, $pageId, $entityIdSer, $itemNamespace ) { + protected function insertPageToDb( DatabaseBase $db, $pageId, $entityIdSer, $itemNamespace ) { $this->tablesUsed[] = 'page'; $db->insert( 'page', @@ -219,7 +219,7 @@ // test an item with only 2 sitelinks and 2 claims $this->insertPageProps( $db, 111, 'Q111', 2, 2, $itemNamespace ); // test an item only in page table, not in pageprops - $this->insertPage( $db, 222, 'Q222', $itemNamespace ); + $this->insertPageToDb( $db, 222, 'Q222', $itemNamespace ); $specialSearch = $this->getSpecialSearch(); $output = new OutputPage( new RequestContext() ); -- To view, visit https://gerrit.wikimedia.org/r/298010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28ef0f12cb534e3584018e2df36b2330319ff364 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticlePlaceholder Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits