[MediaWiki-commits] [Gerrit] Do not show the article selector unless all params passed in... - change (mediawiki...ContentTranslation)
jenkins-bot has submitted this change and it was merged. Change subject: Do not show the article selector unless all params passed in URL .. Do not show the article selector unless all params passed in URL It seems that showing this dialog even with partially filled params (for example, contribution menu entry point fills the target lang param) creates confusion to users and they re-type title and end up in creating a fresh translation that overwrites an in-progress translation. Target title is not validated for this, since it is optional. Bug: T104702 Change-Id: Iff73f4bedbb1038d70ca26e087550ddb64261220 --- M modules/source/ext.cx.source.selector.js 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Amire80: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/source/ext.cx.source.selector.js b/modules/source/ext.cx.source.selector.js index f32d532..c8c8ca3 100644 --- a/modules/source/ext.cx.source.selector.js +++ b/modules/source/ext.cx.source.selector.js @@ -100,10 +100,10 @@ this.$targetTitleInput.val( this.options.targetTitle ).trigger( 'input' ); } - // If any of the values are already present, + // If all of the values are already present, // show the dialog and initiate a validation. - if ( this.options.sourceLanguage || this.options.targetLanguage || - this.options.sourceTitle || this.options.targetTitle + if ( this.options.sourceLanguage this.options.targetLanguage + this.options.sourceTitle ) { this.show(); this.check(); -- To view, visit https://gerrit.wikimedia.org/r/227643 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff73f4bedbb1038d70ca26e087550ddb64261220 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not show the article selector unless all params passed in... - change (mediawiki...ContentTranslation)
Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/227643 Change subject: Do not show the article selector unless all params passed in URL .. Do not show the article selector unless all params passed in URL It seems showing this dialog even with partially fillted params( for example, contribution menu entry point fills the target lang param) creates confusion to users and they re-type title and end up in creating a fresh translation that overwrites an in-progress translation Bug: T104702 Change-Id: Iff73f4bedbb1038d70ca26e087550ddb64261220 --- M modules/source/ext.cx.source.selector.js 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/43/227643/1 diff --git a/modules/source/ext.cx.source.selector.js b/modules/source/ext.cx.source.selector.js index f32d532..74fc172 100644 --- a/modules/source/ext.cx.source.selector.js +++ b/modules/source/ext.cx.source.selector.js @@ -100,10 +100,10 @@ this.$targetTitleInput.val( this.options.targetTitle ).trigger( 'input' ); } - // If any of the values are already present, + // If all of the values are already present, // show the dialog and initiate a validation. - if ( this.options.sourceLanguage || this.options.targetLanguage || - this.options.sourceTitle || this.options.targetTitle + if ( this.options.sourceLanguage this.options.targetLanguage + this.options.sourceTitle this.options.targetTitle ) { this.show(); this.check(); -- To view, visit https://gerrit.wikimedia.org/r/227643 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iff73f4bedbb1038d70ca26e087550ddb64261220 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits