Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227448
Change subject: Don't assume ve exists
......................................................................
Don't assume ve exists
We properly check isSupported before actually using any ve code,
but we blindly pass variable 've' even though it may not exist,
causing a:
ReferenceError: ve is not defined
This is not actually breaking anything, just some console noise.
Change-Id: Ie04298960cad187d920e230c2c91f691936b405d
---
M modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/48/227448/1
diff --git
a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
index 4725051..e9e6071 100644
--- a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
+++ b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
@@ -215,4 +215,4 @@
);
};
-}( jQuery, mediaWiki, OO, ve ) );
+}( jQuery, mediaWiki, OO, ve ? ve : null ) );
--
To view, visit https://gerrit.wikimedia.org/r/227448
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie04298960cad187d920e230c2c91f691936b405d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
