[MediaWiki-commits] [Gerrit] Don't force focus after history action - change (VisualEditor/VisualEditor)

2014-10-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Don't force focus after history action
..


Don't force focus after history action

These days the surface correctly takes focus if necessary so this
is unnecessary and may cause unwanted scrolling when the selection
should be in the paste target.

Change-Id: Ib5fc40515a8c8780a4fee6e928d1e6322a2b7409
---
M src/ui/actions/ve.ui.HistoryAction.js
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/ui/actions/ve.ui.HistoryAction.js 
b/src/ui/actions/ve.ui.HistoryAction.js
index 23f4a9d..fae14a1 100644
--- a/src/ui/actions/ve.ui.HistoryAction.js
+++ b/src/ui/actions/ve.ui.HistoryAction.js
@@ -42,7 +42,6 @@
  */
 ve.ui.HistoryAction.prototype.undo = function () {
this.surface.getModel().undo();
-   this.surface.getView().focus();
 };
 
 /**
@@ -52,7 +51,6 @@
  */
 ve.ui.HistoryAction.prototype.redo = function () {
this.surface.getModel().redo();
-   this.surface.getView().focus();
 };
 
 /* Registration */

-- 
To view, visit https://gerrit.wikimedia.org/r/166424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5fc40515a8c8780a4fee6e928d1e6322a2b7409
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't force focus after history action - change (VisualEditor/VisualEditor)

2014-10-13 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/166424

Change subject: Don't force focus after history action
..

Don't force focus after history action

These days the surface correctly takes focus if necessary so this
is unnecessary and may cause unwanted scrolling when the selection
should be in the paste target.
focus away from the paste target.

Change-Id: Ib5fc40515a8c8780a4fee6e928d1e6322a2b7409
---
M src/ui/actions/ve.ui.HistoryAction.js
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/24/166424/1

diff --git a/src/ui/actions/ve.ui.HistoryAction.js 
b/src/ui/actions/ve.ui.HistoryAction.js
index 23f4a9d..fae14a1 100644
--- a/src/ui/actions/ve.ui.HistoryAction.js
+++ b/src/ui/actions/ve.ui.HistoryAction.js
@@ -42,7 +42,6 @@
  */
 ve.ui.HistoryAction.prototype.undo = function () {
this.surface.getModel().undo();
-   this.surface.getView().focus();
 };
 
 /**
@@ -52,7 +51,6 @@
  */
 ve.ui.HistoryAction.prototype.redo = function () {
this.surface.getModel().redo();
-   this.surface.getView().focus();
 };
 
 /* Registration */

-- 
To view, visit https://gerrit.wikimedia.org/r/166424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5fc40515a8c8780a4fee6e928d1e6322a2b7409
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits