[MediaWiki-commits] [Gerrit] Don't hardcode timestamp format in UUID helper method - change (mediawiki...Flow)
jenkins-bot has submitted this change and it was merged.
Change subject: Don't hardcode timestamp format in UUID helper method
..
Don't hardcode timestamp format in UUID helper method
Change-Id: I1531e519f5d40e5dba11ecbbdb0a697e2f2b23e3
---
M includes/Model/UUID.php
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Model/UUID.php b/includes/Model/UUID.php
index 828b96c..bffc080 100644
--- a/includes/Model/UUID.php
+++ b/includes/Model/UUID.php
@@ -270,11 +270,14 @@
}
/**
-* @return string Timestamp in TS_MW format
+* Returns the timestamp in the desired format (defaults to TS_MW)
+*
+* @param string $format Desired format
+* @return string
*/
- public function getTimestamp() {
+ public function getTimestamp( $format = TS_MW ) {
$ts = $this->getTimestampObj();
- return $ts->getTimestamp( TS_MW );
+ return $ts->getTimestamp( $format );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/167220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1531e519f5d40e5dba11ecbbdb0a697e2f2b23e3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie
Gerrit-Reviewer: EBernhardson
Gerrit-Reviewer: SG
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't hardcode timestamp format in UUID helper method - change (mediawiki...Flow)
Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167220
Change subject: Don't hardcode timestamp format in UUID helper method
..
Don't hardcode timestamp format in UUID helper method
Change-Id: I1531e519f5d40e5dba11ecbbdb0a697e2f2b23e3
---
M includes/Model/UUID.php
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/20/167220/1
diff --git a/includes/Model/UUID.php b/includes/Model/UUID.php
index c4b612c..55704de 100644
--- a/includes/Model/UUID.php
+++ b/includes/Model/UUID.php
@@ -277,11 +277,14 @@
}
/**
-* @return string Timestamp in TS_MW format
+* Returns the timestamp in the desired format (defaults to TS_MW)
+*
+* @param string $format Desired format
+* @return string
*/
- public function getTimestamp() {
+ public function getTimestamp( $format = TS_MW ) {
$ts = $this->getTimestampObj();
- return $ts->getTimestamp( TS_MW );
+ return $ts->getTimestamp( $format );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/167220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1531e519f5d40e5dba11ecbbdb0a697e2f2b23e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
