[MediaWiki-commits] [Gerrit] Don't load talk overlay code on talk pages - change (mediawiki...MobileFrontend)

2014-11-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Don't load talk overlay code on talk pages
..


Don't load talk overlay code on talk pages

It's unneded there.

Bug: 72799
Change-Id: Idf57dec830211d38f1e0d5ea634cd19d605f090f
---
M includes/skins/SkinMinervaBeta.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/skins/SkinMinervaBeta.php 
b/includes/skins/SkinMinervaBeta.php
index 47cb640..098beb3 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -33,7 +33,8 @@
 */
public function getDefaultModules() {
$modules = parent::getDefaultModules();
-   if ( $this-isAllowedPageAction( 'talk' ) ) {
+   $title = $this-getTitle();
+   if ( $this-isAllowedPageAction( 'talk' )  
!$title-isTalkPage() ) {
$modules['talk'] = array( 'mobile.talk' );
}
$modules['beta'] = array( 'mobile.beta' );

-- 
To view, visit https://gerrit.wikimedia.org/r/173532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf57dec830211d38f1e0d5ea634cd19d605f090f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow florian.schmidt.wel...@t-online.de
Gerrit-Reviewer: Awjrichards aricha...@wikimedia.org
Gerrit-Reviewer: Bmansurov bmansu...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't load talk overlay code on talk pages - change (mediawiki...MobileFrontend)

2014-11-15 Thread Florianschmidtwelzow (Code Review) 
Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173532

Change subject: Don't load talk overlay code on talk pages
..

Don't load talk overlay code on talk pages

It's unneded there.

Bug: 72799
Change-Id: Idf57dec830211d38f1e0d5ea634cd19d605f090f
---
M includes/skins/SkinMinervaBeta.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/32/173532/1

diff --git a/includes/skins/SkinMinervaBeta.php 
b/includes/skins/SkinMinervaBeta.php
index 47cb640..098beb3 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -33,7 +33,8 @@
 */
public function getDefaultModules() {
$modules = parent::getDefaultModules();
-   if ( $this-isAllowedPageAction( 'talk' ) ) {
+   $title = $this-getTitle();
+   if ( $this-isAllowedPageAction( 'talk' )  
!$title-isTalkPage() ) {
$modules['talk'] = array( 'mobile.talk' );
}
$modules['beta'] = array( 'mobile.beta' );

-- 
To view, visit https://gerrit.wikimedia.org/r/173532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf57dec830211d38f1e0d5ea634cd19d605f090f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow florian.schmidt.wel...@t-online.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits