[MediaWiki-commits] [Gerrit] Don't show debug CBN highlight in test mode - change (VisualEditor/VisualEditor)

2015-05-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Don't show debug CBN highlight in test mode
..


Don't show debug CBN highlight in test mode

This is causing CE HTML tests to fail as we aren't expecting
the inline CSS this generates.

Change-Id: Ic1e4cc783b84dab4a1c3cffe27591abf5075dbf5
---
M src/ce/ve.ce.ContentBranchNode.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/ce/ve.ce.ContentBranchNode.js 
b/src/ce/ve.ce.ContentBranchNode.js
index 234ea15..45a93e8 100644
--- a/src/ce/ve.ce.ContentBranchNode.js
+++ b/src/ce/ve.ce.ContentBranchNode.js
@@ -403,7 +403,7 @@
this.setupInlineSlugs();
 
// Highlight the node in debug mode
-   if ( ve.debug ) {
+   if ( ve.debug && !ve.test ) {
this.$element.css( 'backgroundColor', '#eee' );
setTimeout( function () {
node.$element.css( 'backgroundColor', '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/211403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1e4cc783b84dab4a1c3cffe27591abf5075dbf5
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't show debug CBN highlight in test mode - change (VisualEditor/VisualEditor)

2015-05-16 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211403

Change subject: Don't show debug CBN highlight in test mode
..

Don't show debug CBN highlight in test mode

This is causing CE HTML tests to fail as we aren't expecting
the inline CSS this generates.

Change-Id: Ic1e4cc783b84dab4a1c3cffe27591abf5075dbf5
---
M src/ce/ve.ce.ContentBranchNode.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/03/211403/1

diff --git a/src/ce/ve.ce.ContentBranchNode.js 
b/src/ce/ve.ce.ContentBranchNode.js
index 234ea15..45a93e8 100644
--- a/src/ce/ve.ce.ContentBranchNode.js
+++ b/src/ce/ve.ce.ContentBranchNode.js
@@ -403,7 +403,7 @@
this.setupInlineSlugs();
 
// Highlight the node in debug mode
-   if ( ve.debug ) {
+   if ( ve.debug && !ve.test ) {
this.$element.css( 'backgroundColor', '#eee' );
setTimeout( function () {
node.$element.css( 'backgroundColor', '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/211403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1e4cc783b84dab4a1c3cffe27591abf5075dbf5
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits