jenkins-bot has submitted this change and it was merged.
Change subject: Don't transmit zero-result search events in TitleSearchFragment
funnel.
......................................................................
Don't transmit zero-result search events in TitleSearchFragment funnel.
The search funnel is meant to track user-perceived performance of search, and
since the autoswitching means the user never perceives a zero result event for
a title search, it doesn't make sense to log it.
Change-Id: Ie974ef89eb3ff15a608ee3303b1c8574a78f136f
---
M wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
index 988211d..c864453 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
@@ -294,7 +294,11 @@
if (!isAdded()) {
return;
}
- searchFragment.getFunnel().searchResults(false,
result.size(), (int)(System.currentTimeMillis() - startMillis));
+ // To ease data analysis and better make the funnel track
with user behaviour,
+ // only transmit search results events if there are a
nonzero number of results
+ if (result.size() > 0) {
+ searchFragment.getFunnel().searchResults(false,
result.size(), (int) (System.currentTimeMillis() - startMillis));
+ }
((PageActivity)getActivity()).updateProgressBar(false,
true, 0);
searchNetworkError.setVisibility(View.GONE);
displayResults(result);
--
To view, visit https://gerrit.wikimedia.org/r/181429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie974ef89eb3ff15a608ee3303b1c8574a78f136f
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
