[MediaWiki-commits] [Gerrit] Don't try to fetch non-existing extension data from ParserOu... - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Don't try to fetch non-existing extension data from ParserOutput .. Don't try to fetch non-existing extension data from ParserOutput wikibase-configvars is not used and nothing saved there, since we instead add this stuff to the JS config vars directly. Change-Id: I2f1fc63118dab4cc1d5a8124785658d21bacbd02 --- M repo/Wikibase.hooks.php 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php index a1140ce..16d9b06 100644 --- a/repo/Wikibase.hooks.php +++ b/repo/Wikibase.hooks.php @@ -1053,9 +1053,6 @@ $out-setProperty( 'wikibase-view-chunks', $placeholders ); } - $configVars = $parserOutput-getExtensionData( 'wikibase-configvars' ); - $out-setProperty( 'wikibase-configvars', $configVars ); - return true; } -- To view, visit https://gerrit.wikimedia.org/r/167123 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f1fc63118dab4cc1d5a8124785658d21bacbd02 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't try to fetch non-existing extension data from ParserOu... - change (mediawiki...Wikibase)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/167123 Change subject: Don't try to fetch non-existing extension data from ParserOutput .. Don't try to fetch non-existing extension data from ParserOutput wikibase-configvars is not used and nothing saved there, since we instead add this stuff to the JS config vars directly. Change-Id: I2f1fc63118dab4cc1d5a8124785658d21bacbd02 --- M repo/Wikibase.hooks.php 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/23/167123/1 diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php index a1140ce..16d9b06 100644 --- a/repo/Wikibase.hooks.php +++ b/repo/Wikibase.hooks.php @@ -1053,9 +1053,6 @@ $out-setProperty( 'wikibase-view-chunks', $placeholders ); } - $configVars = $parserOutput-getExtensionData( 'wikibase-configvars' ); - $out-setProperty( 'wikibase-configvars', $configVars ); - return true; } -- To view, visit https://gerrit.wikimedia.org/r/167123 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f1fc63118dab4cc1d5a8124785658d21bacbd02 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
