[MediaWiki-commits] [Gerrit] Don't use $wgContentNamespaces directly - change (mediawiki...DuskToDawn)

2016-06-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Don't use $wgContentNamespaces directly
..


Don't use $wgContentNamespaces directly

Change-Id: I193c51e527501efea0fa0f84614ff0f67f69b115
---
M DuskToDawn.skin.php
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/DuskToDawn.skin.php b/DuskToDawn.skin.php
index 4f84e15..ed6323c 100644
--- a/DuskToDawn.skin.php
+++ b/DuskToDawn.skin.php
@@ -54,12 +54,10 @@
 * Almost verbatim copypasta from Aurora (/skins/Aurora/Aurora.skin.php)
 */
private function getLastEdited() {
-   global $wgContentNamespaces;
-
$title = $this->getSkin()->getTitle();
$msg = '';
 
-   if ( $title->exists() && in_array( $title->getNamespace(), 
$wgContentNamespaces ) ) {
+   if ( $title->exists() && $title->isContentPage() ) {
// First construct a Revision object from the current 
Title...
$revision = Revision::newFromTitle( $title );
if ( $revision instanceof Revision ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/291267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I193c51e527501efea0fa0f84614ff0f67f69b115
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/DuskToDawn
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't use $wgContentNamespaces directly - change (mediawiki...DuskToDawn)

2016-05-27 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291267

Change subject: Don't use $wgContentNamespaces directly
..

Don't use $wgContentNamespaces directly

Change-Id: I193c51e527501efea0fa0f84614ff0f67f69b115
---
M DuskToDawn.skin.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/DuskToDawn 
refs/changes/67/291267/1

diff --git a/DuskToDawn.skin.php b/DuskToDawn.skin.php
index 4f84e15..ed6323c 100644
--- a/DuskToDawn.skin.php
+++ b/DuskToDawn.skin.php
@@ -54,12 +54,10 @@
 * Almost verbatim copypasta from Aurora (/skins/Aurora/Aurora.skin.php)
 */
private function getLastEdited() {
-   global $wgContentNamespaces;
-
$title = $this->getSkin()->getTitle();
$msg = '';
 
-   if ( $title->exists() && in_array( $title->getNamespace(), 
$wgContentNamespaces ) ) {
+   if ( $title->exists() && $title->isContentPage() ) {
// First construct a Revision object from the current 
Title...
$revision = Revision::newFromTitle( $title );
if ( $revision instanceof Revision ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/291267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I193c51e527501efea0fa0f84614ff0f67f69b115
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/DuskToDawn
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits