[MediaWiki-commits] [Gerrit] Drop mw:ExtLink/URL support - change (mediawiki...VisualEditor)

2013-07-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Drop mw:ExtLink/URL support
..


Drop mw:ExtLink/URL support

Because Parsoid has.

Bug: 50734
Change-Id: Id2c893467c5063cc29cd9a91203406b86a3abfbe
---
M modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
M modules/ve-mw/test/dm/ve.dm.mwExample.js
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js 
b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
index 85bf863..44654e6 100644
--- a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
+++ b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
@@ -11,7 +11,6 @@
  * Example HTML sources:
  * a rel=mw:ExtLink
  * a rel=mw:ExtLink/Numbered
- * a rel=mw:ExtLink/URL
  *
  * Each example is semantically slightly different, but they don't need 
special treatment (yet).
  *
@@ -34,7 +33,8 @@
 ve.dm.MWExternalLinkAnnotation.static.name = 'link/mwExternal';
 
 ve.dm.MWExternalLinkAnnotation.static.matchRdfaTypes = [
-   'mw:ExtLink', 'mw:ExtLink/Numbered', 'mw:ExtLink/URL'
+   'mw:ExtLink',
+   'mw:ExtLink/Numbered'
 ];
 
 ve.dm.MWExternalLinkAnnotation.static.toDataElement = function ( domElements ) 
{
diff --git a/modules/ve-mw/test/dm/ve.dm.mwExample.js 
b/modules/ve-mw/test/dm/ve.dm.mwExample.js
index ec6bd20..68c09e6 100644
--- a/modules/ve-mw/test/dm/ve.dm.mwExample.js
+++ b/modules/ve-mw/test/dm/ve.dm.mwExample.js
@@ -1187,7 +1187,7 @@
]
},
'URL link': {
-   'html': 'bodypa rel=mw:ExtLink/URL 
href=http://www.mediawiki.org/;mw/a/p/body',
+   'html': 'bodypa rel=mw:ExtLink 
href=http://www.mediawiki.org/;mw/a/p/body',
'data': [
{ 'type': 'paragraph' },
[
@@ -1196,10 +1196,10 @@
'type': 'link/mwExternal',
'attributes': {
'href': 
'http://www.mediawiki.org/',
-   'rel': 'mw:ExtLink/URL'
+   'rel': 'mw:ExtLink'
},
'htmlAttributes': [ { 'values': {
-   'rel': 'mw:ExtLink/URL',
+   'rel': 'mw:ExtLink',
'href': 
'http://www.mediawiki.org/'
} } ]
} ]
@@ -1210,10 +1210,10 @@
'type': 'link/mwExternal',
'attributes': {
'href': 
'http://www.mediawiki.org/',
-   'rel': 'mw:ExtLink/URL'
+   'rel': 'mw:ExtLink'
},
'htmlAttributes': [ { 'values': {
-   'rel': 'mw:ExtLink/URL',
+   'rel': 'mw:ExtLink',
'href': 
'http://www.mediawiki.org/'
} } ]
} ]

-- 
To view, visit https://gerrit.wikimedia.org/r/71974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2c893467c5063cc29cd9a91203406b86a3abfbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Drop mw:ExtLink/URL support - change (mediawiki...VisualEditor)

2013-07-04 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71974


Change subject: Drop mw:ExtLink/URL support
..

Drop mw:ExtLink/URL support

Because Parsoid has.

Bug: 50734
Change-Id: Id2c893467c5063cc29cd9a91203406b86a3abfbe
---
M modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
M modules/ve-mw/test/dm/ve.dm.mwExample.js
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/74/71974/1

diff --git a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js 
b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
index 85bf863..44654e6 100644
--- a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
+++ b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
@@ -11,7 +11,6 @@
  * Example HTML sources:
  * a rel=mw:ExtLink
  * a rel=mw:ExtLink/Numbered
- * a rel=mw:ExtLink/URL
  *
  * Each example is semantically slightly different, but they don't need 
special treatment (yet).
  *
@@ -34,7 +33,8 @@
 ve.dm.MWExternalLinkAnnotation.static.name = 'link/mwExternal';
 
 ve.dm.MWExternalLinkAnnotation.static.matchRdfaTypes = [
-   'mw:ExtLink', 'mw:ExtLink/Numbered', 'mw:ExtLink/URL'
+   'mw:ExtLink',
+   'mw:ExtLink/Numbered'
 ];
 
 ve.dm.MWExternalLinkAnnotation.static.toDataElement = function ( domElements ) 
{
diff --git a/modules/ve-mw/test/dm/ve.dm.mwExample.js 
b/modules/ve-mw/test/dm/ve.dm.mwExample.js
index ec6bd20..68c09e6 100644
--- a/modules/ve-mw/test/dm/ve.dm.mwExample.js
+++ b/modules/ve-mw/test/dm/ve.dm.mwExample.js
@@ -1187,7 +1187,7 @@
]
},
'URL link': {
-   'html': 'bodypa rel=mw:ExtLink/URL 
href=http://www.mediawiki.org/;mw/a/p/body',
+   'html': 'bodypa rel=mw:ExtLink 
href=http://www.mediawiki.org/;mw/a/p/body',
'data': [
{ 'type': 'paragraph' },
[
@@ -1196,10 +1196,10 @@
'type': 'link/mwExternal',
'attributes': {
'href': 
'http://www.mediawiki.org/',
-   'rel': 'mw:ExtLink/URL'
+   'rel': 'mw:ExtLink'
},
'htmlAttributes': [ { 'values': {
-   'rel': 'mw:ExtLink/URL',
+   'rel': 'mw:ExtLink',
'href': 
'http://www.mediawiki.org/'
} } ]
} ]
@@ -1210,10 +1210,10 @@
'type': 'link/mwExternal',
'attributes': {
'href': 
'http://www.mediawiki.org/',
-   'rel': 'mw:ExtLink/URL'
+   'rel': 'mw:ExtLink'
},
'htmlAttributes': [ { 'values': {
-   'rel': 'mw:ExtLink/URL',
+   'rel': 'mw:ExtLink',
'href': 
'http://www.mediawiki.org/'
} } ]
} ]

-- 
To view, visit https://gerrit.wikimedia.org/r/71974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2c893467c5063cc29cd9a91203406b86a3abfbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits