[MediaWiki-commits] [Gerrit] Drop useless docs from Store interface - change (mediawiki...Wikibase)

2014-12-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Drop useless docs from Store interface
..


Drop useless docs from Store interface

Some comments were wrong, must added zero additional information.

Change-Id: Id8410f75c04a303c61fd4ab0206e42d2752e94db
---
M repo/includes/store/Store.php
1 file changed, 1 insertion(+), 25 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/includes/store/Store.php b/repo/includes/store/Store.php
index e21026c..34e7104 100644
--- a/repo/includes/store/Store.php
+++ b/repo/includes/store/Store.php
@@ -26,13 +26,9 @@
 interface Store {
 
/**
-* Returns a new SiteLinkCache for this store.
-*
 * @since 0.1
 *
 * @return SiteLinkCache
-*
-* @todo: rename to newSiteLinkIndex
 */
public function newSiteLinkCache();
 
@@ -44,15 +40,13 @@
public function clear();
 
/**
-* Rebuilds the store.
+* Rebuilds the store from the original data source.
 *
 * @since 0.1
 */
public function rebuild();
 
/**
-* Returns a TermIndex for this store.
-*
 * @since 0.4
 *
 * @return TermIndex
@@ -60,8 +54,6 @@
public function getTermIndex();
 
/**
-* Returns a TermIndex for this store.
-*
 * @since 0.5
 *
 * @return LabelConflictFinder
@@ -69,8 +61,6 @@
public function getLabelConflictFinder();
 
/**
-* Returns a new IdGenerator for this store.
-*
 * @since 0.1
 *
 * @return IdGenerator
@@ -78,8 +68,6 @@
public function newIdGenerator();
 
/**
-* Return a new EntityPerPage.
-*
 * @since 0.3
 *
 * @return EntityPerPage
@@ -87,8 +75,6 @@
public function newEntityPerPage();
 
/**
-* Returns an EntityLookup
-*
 * @since 0.4
 *
 * @param string $uncached Flag string, set to 'uncached' to get an 
uncached direct lookup service.
@@ -98,8 +84,6 @@
public function getEntityLookup( $uncached = '' );
 
/**
-* Returns an EntityRevisionLookup
-*
 * @since 0.5
 *
 * @param string $uncached Flag string, set to 'uncached' to get an 
uncached direct lookup service.
@@ -109,8 +93,6 @@
public function getEntityRevisionLookup( $uncached = '' );
 
/**
-* Returns an EntityStore
-*
 * @since 0.5
 *
 * @return EntityStore
@@ -128,8 +110,6 @@
public function getEntityStoreWatcher();
 
/**
-* Returns an EntityInfoBuilder
-*
 * @since 0.5
 *
 * @return EntityInfoBuilderFactory
@@ -137,8 +117,6 @@
public function getEntityInfoBuilderFactory();
 
/**
-* Returns a PropertyInfoStore
-*
 * @since 0.4
 *
 * @return PropertyInfoStore
@@ -146,8 +124,6 @@
public function getPropertyInfoStore();
 
/**
-* Returns a ChangesTable
-*
 * @since 0.5
 *
 * @return ChangesTable

-- 
To view, visit https://gerrit.wikimedia.org/r/179937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8410f75c04a303c61fd4ab0206e42d2752e94db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Drop useless docs from Store interface - change (mediawiki...Wikibase)

2014-12-15 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179937

Change subject: Drop useless docs from Store interface
..

Drop useless docs from Store interface

Some comments were wrong, must added zero additional information.

Change-Id: Id8410f75c04a303c61fd4ab0206e42d2752e94db
---
M repo/includes/store/Store.php
1 file changed, 1 insertion(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/37/179937/1

diff --git a/repo/includes/store/Store.php b/repo/includes/store/Store.php
index e21026c..34e7104 100644
--- a/repo/includes/store/Store.php
+++ b/repo/includes/store/Store.php
@@ -26,13 +26,9 @@
 interface Store {
 
/**
-* Returns a new SiteLinkCache for this store.
-*
 * @since 0.1
 *
 * @return SiteLinkCache
-*
-* @todo: rename to newSiteLinkIndex
 */
public function newSiteLinkCache();
 
@@ -44,15 +40,13 @@
public function clear();
 
/**
-* Rebuilds the store.
+* Rebuilds the store from the original data source.
 *
 * @since 0.1
 */
public function rebuild();
 
/**
-* Returns a TermIndex for this store.
-*
 * @since 0.4
 *
 * @return TermIndex
@@ -60,8 +54,6 @@
public function getTermIndex();
 
/**
-* Returns a TermIndex for this store.
-*
 * @since 0.5
 *
 * @return LabelConflictFinder
@@ -69,8 +61,6 @@
public function getLabelConflictFinder();
 
/**
-* Returns a new IdGenerator for this store.
-*
 * @since 0.1
 *
 * @return IdGenerator
@@ -78,8 +68,6 @@
public function newIdGenerator();
 
/**
-* Return a new EntityPerPage.
-*
 * @since 0.3
 *
 * @return EntityPerPage
@@ -87,8 +75,6 @@
public function newEntityPerPage();
 
/**
-* Returns an EntityLookup
-*
 * @since 0.4
 *
 * @param string $uncached Flag string, set to 'uncached' to get an 
uncached direct lookup service.
@@ -98,8 +84,6 @@
public function getEntityLookup( $uncached = '' );
 
/**
-* Returns an EntityRevisionLookup
-*
 * @since 0.5
 *
 * @param string $uncached Flag string, set to 'uncached' to get an 
uncached direct lookup service.
@@ -109,8 +93,6 @@
public function getEntityRevisionLookup( $uncached = '' );
 
/**
-* Returns an EntityStore
-*
 * @since 0.5
 *
 * @return EntityStore
@@ -128,8 +110,6 @@
public function getEntityStoreWatcher();
 
/**
-* Returns an EntityInfoBuilder
-*
 * @since 0.5
 *
 * @return EntityInfoBuilderFactory
@@ -137,8 +117,6 @@
public function getEntityInfoBuilderFactory();
 
/**
-* Returns a PropertyInfoStore
-*
 * @since 0.4
 *
 * @return PropertyInfoStore
@@ -146,8 +124,6 @@
public function getPropertyInfoStore();
 
/**
-* Returns a ChangesTable
-*
 * @since 0.5
 *
 * @return ChangesTable

-- 
To view, visit https://gerrit.wikimedia.org/r/179937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8410f75c04a303c61fd4ab0206e42d2752e94db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits