[MediaWiki-commits] [Gerrit] Enable RPS on eth0 on labstores - change (operations/puppet)

2016-01-26 Thread Rush (Code Review)
Rush has submitted this change and it was merged.

Change subject: Enable RPS on eth0 on labstores
..


Enable RPS on eth0 on labstores

During recent Labs NFS overload situations, we've seen timeouts on
CPU #0 and ksoftirqd/0 consuming high amount of CPU. A quick look
in /proc/interrupts reveals why: all network interrupts (and
megasas as well) are being handled by CPU #0. No irqbalance running
either.

This naive patch enables Receive Packet Steering (RPS), which will
hopefully improve the situation, but may need further tweaking.

Change-Id: I28780014759fb0cbf4d0123cae1ae0c233a515b2
---
M modules/role/manifests/labs/nfs/fileserver.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Rush: Looks good to me, approved
  coren: Looks good to me, but someone else must approve
  BBlack: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/role/manifests/labs/nfs/fileserver.pp 
b/modules/role/manifests/labs/nfs/fileserver.pp
index ee01956..cf09d59 100644
--- a/modules/role/manifests/labs/nfs/fileserver.pp
+++ b/modules/role/manifests/labs/nfs/fileserver.pp
@@ -7,6 +7,9 @@
 include standard
 include ::labstore::fileserver
 
+# Enable RPS to balance IRQs over CPUs
+interface::rps { $monitor: }
+
 class { '::labstore::monitoring':
 monitor_iface => $monitor,
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/261598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28780014759fb0cbf4d0123cae1ae0c233a515b2
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Chasemp 
Gerrit-Reviewer: Mark Bergsma 
Gerrit-Reviewer: Rush 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: coren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Enable RPS on eth0 on labstores - change (operations/puppet)

2015-12-29 Thread Mark Bergsma (Code Review)
Mark Bergsma has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/261598

Change subject: Enable RPS on eth0 on labstores
..

Enable RPS on eth0 on labstores

During recent Labs NFS overload situations, we've seen timeouts on
CPU #0 and ksoftirqd/0 consuming high amount of CPU. A quick look
in /proc/interrupts reveals why: all network interrupts (and
megasas as well) are being handled by CPU #0. No irqbalance running
either.

This naive patch enables Receive Packet Steering (RPS), which will
hopefully improve the situation, but may need further tweaking.

Change-Id: I28780014759fb0cbf4d0123cae1ae0c233a515b2
---
M modules/role/manifests/labs/nfs/fileserver.pp
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/261598/1

diff --git a/modules/role/manifests/labs/nfs/fileserver.pp 
b/modules/role/manifests/labs/nfs/fileserver.pp
index ee01956..29b2bdd 100644
--- a/modules/role/manifests/labs/nfs/fileserver.pp
+++ b/modules/role/manifests/labs/nfs/fileserver.pp
@@ -7,6 +7,9 @@
 include standard
 include ::labstore::fileserver
 
+# Enable RPS/RSS to balance IRQs over CPUs
+interface::rps { 'eth0': }
+
 class { '::labstore::monitoring':
 monitor_iface => $monitor,
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/261598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28780014759fb0cbf4d0123cae1ae0c233a515b2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits