[MediaWiki-commits] [Gerrit] Escape special namespaces in some messages - change (mediawiki...Translate)
jenkins-bot has submitted this change and it was merged. Change subject: Escape special namespaces in some messages .. Escape special namespaces in some messages Four messages were not wikitext-escaped, so it was interpreted on Category: and File: namespaces as a special syntax. Bug: 44864 Change-Id: Ib319bfd5e1d0297d6daae3f49bd33ca245ec9249 --- M tag/PageTranslationHooks.php M tag/SpecialPageTranslation.php 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php index f20cfa4..46cc7e8 100644 --- a/tag/PageTranslationHooks.php +++ b/tag/PageTranslationHooks.php @@ -603,7 +603,7 @@ list( , $code ) = TranslateUtils::figureMessage( $title-getText() ); $result = array( 'tpt-target-page', - $page-getTitle()-getPrefixedText(), + ':' . $page-getTitle()-getPrefixedText(), // This url shouldn't get cached wfExpandUrl( $page-getTranslationUrl( $code ) ) ); @@ -753,7 +753,7 @@ $wrap = 'div class=mw-translate-page-info$1/div'; $out = RequestContext::getMain()-getOutput(); - $out-wrapWikiMsg( $wrap, array( 'tpt-translation-intro', $url, $titleText, $per ) ); + $out-wrapWikiMsg( $wrap, array( 'tpt-translation-intro', $url, ':' . $titleText, $per ) ); $out-addHTML( 'hr /' ); } diff --git a/tag/SpecialPageTranslation.php b/tag/SpecialPageTranslation.php index 7898220..0a11160 100644 --- a/tag/SpecialPageTranslation.php +++ b/tag/SpecialPageTranslation.php @@ -128,7 +128,7 @@ // We do want to notify the reviewer if the underlying page changes during review $target = $title-getFullUrl( array( 'oldid' = $revision ) ); $link = span class='plainlinks'[$target $revision]/span; - $out-addWikiMsg( 'tpt-oldrevision', $title-getPrefixedText(), $link ); + $out-addWikiMsg( 'tpt-oldrevision', ':' . $title-getPrefixedText(), $link ); return; } @@ -171,7 +171,7 @@ $link = SpecialPage::getTitleFor( 'Translate' )-getFullUrl( array( 'group' = $page-getMessageGroupId() ) ); - $this-getOutput()-addWikiMsg( 'tpt-saveok', $titleText, $num, $link ); + $this-getOutput()-addWikiMsg( 'tpt-saveok', ':' . $titleText, $num, $link ); // If TranslationNotifications is installed, and the user can notify // translators, add a convenience link. if ( method_exists( 'SpecialNotifyTranslators', 'execute' ) -- To view, visit https://gerrit.wikimedia.org/r/104204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib319bfd5e1d0297d6daae3f49bd33ca245ec9249 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Seb35 seb35wikipe...@gmail.com Gerrit-Reviewer: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Seb35 seb35wikipe...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Escape special namespaces in some messages - change (mediawiki...Translate)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/104204 Change subject: Escape special namespaces in some messages .. Escape special namespaces in some messages Four messages were not wikitext-escaped, so it was interpreted on Category: and File: namespaces as a special syntax. Bug: 44864 Change-Id: Ib319bfd5e1d0297d6daae3f49bd33ca245ec9249 --- M tag/PageTranslationHooks.php M tag/SpecialPageTranslation.php 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/04/104204/1 diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php index f20cfa4..248387e 100644 --- a/tag/PageTranslationHooks.php +++ b/tag/PageTranslationHooks.php @@ -603,7 +603,7 @@ list( , $code ) = TranslateUtils::figureMessage( $title-getText() ); $result = array( 'tpt-target-page', - $page-getTitle()-getPrefixedText(), + ':'.$page-getTitle()-getPrefixedText(), // This url shouldn't get cached wfExpandUrl( $page-getTranslationUrl( $code ) ) ); @@ -753,7 +753,7 @@ $wrap = 'div class=mw-translate-page-info$1/div'; $out = RequestContext::getMain()-getOutput(); - $out-wrapWikiMsg( $wrap, array( 'tpt-translation-intro', $url, $titleText, $per ) ); + $out-wrapWikiMsg( $wrap, array( 'tpt-translation-intro', $url, ':'.$titleText, $per ) ); $out-addHTML( 'hr /' ); } diff --git a/tag/SpecialPageTranslation.php b/tag/SpecialPageTranslation.php index 7898220..c22462e 100644 --- a/tag/SpecialPageTranslation.php +++ b/tag/SpecialPageTranslation.php @@ -128,7 +128,7 @@ // We do want to notify the reviewer if the underlying page changes during review $target = $title-getFullUrl( array( 'oldid' = $revision ) ); $link = span class='plainlinks'[$target $revision]/span; - $out-addWikiMsg( 'tpt-oldrevision', $title-getPrefixedText(), $link ); + $out-addWikiMsg( 'tpt-oldrevision', ':'.$title-getPrefixedText(), $link ); return; } @@ -171,7 +171,7 @@ $link = SpecialPage::getTitleFor( 'Translate' )-getFullUrl( array( 'group' = $page-getMessageGroupId() ) ); - $this-getOutput()-addWikiMsg( 'tpt-saveok', $titleText, $num, $link ); + $this-getOutput()-addWikiMsg( 'tpt-saveok', ':'.$titleText, $num, $link ); // If TranslationNotifications is installed, and the user can notify // translators, add a convenience link. if ( method_exists( 'SpecialNotifyTranslators', 'execute' ) -- To view, visit https://gerrit.wikimedia.org/r/104204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib319bfd5e1d0297d6daae3f49bd33ca245ec9249 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Seb35 seb35wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
